chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2796783005: MD Settings: Google Play Store: Add subpage and polish (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2796783005: MD Settings: Google Play Store: Add subpage and polish (Take 2) (Closed)

Patch Set: nit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/test/data/webui/settings/android_apps_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 45c902cf43aeff32a82126b177c7964dfb22fbbc..779a6882aced4e32e90a8a5392eb0b4cb268fc39 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -294,18 +294,25 @@ void AddAccountUITweaksStrings(content::WebUIDataSource* html_source,

void AddAndroidAppStrings(content::WebUIDataSource* html_source) {

LocalizedString localized_strings[] = {

{"androidAppsPageTitle", IDS_SETTINGS_ANDROID_APPS_TITLE},

- {"androidAppsEnabled", IDS_SETTINGS_ANDROID_APPS_ENABLE},

+ {"androidAppsPageLabel", IDS_SETTINGS_ANDROID_APPS_LABEL},

+ {"androidAppsEnable", IDS_SETTINGS_ANDROID_APPS_ENABLE},

{"androidAppsManageApps", IDS_SETTINGS_ANDROID_APPS_MANAGE_APPS},

+ {"androidAppsRemove", IDS_SETTINGS_ANDROID_APPS_REMOVE},

{"androidAppsLearnMore", IDS_SETTINGS_ANDROID_APPS_LEARN_MORE},

{"androidAppsDisableDialogTitle",

IDS_SETTINGS_ANDROID_APPS_DISABLE_DIALOG_TITLE},

{"androidAppsDisableDialogMessage",

IDS_SETTINGS_ANDROID_APPS_DISABLE_DIALOG_MESSAGE},

+ {"androidAppsDisableDialogRemove",

+ IDS_SETTINGS_ANDROID_APPS_DISABLE_DIALOG_REMOVE},

};

AddLocalizedStringsBulk(html_source, localized_strings,

arraysize(localized_strings));

- html_source->AddString("androidAppsLearnMoreUrl",

- chrome::kAndroidAppsLearnMoreURL);

+ html_source->AddString(

+ "androidAppsSubtext",

+ l10n_util::GetStringFUTF16(

+ IDS_SETTINGS_ANDROID_APPS_SUBTEXT,

+ base::ASCIIToUTF16(chrome::kAndroidAppsLearnMoreURL)));

}

#endif