Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2796773002: [Android WebAPKs] Force navigation on launch by default (Closed)

Created:
3 years, 8 months ago by pkotwicz
Modified:
3 years, 8 months ago
Reviewers:
dominickn, Xi Han
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebAPKs] Force navigation on launch by default https://codereview.chromium.org/2758193002/ added EXTRA_WEBAPK_FORCE_NAVIGATION to enable WebAPK to specify whether to navigate the WebAPK to the start URL in the intent if the WebAPK is already running (WebApkActivity#onNewIntent). This CL fixes a regression caused by https://codereview.chromium.org/2758193002/ where the WebAPK would not navigate to the passed in URL if EXTRA_WEBAPK_FORCE_NAVIGATION is not specified. In particular, this broke deep links for WebAPKs which have not yet updated. BUG=707590 Review-Url: https://codereview.chromium.org/2796773002 Cr-Commit-Position: refs/heads/master@{#462612} Committed: https://chromium.googlesource.com/chromium/src/+/c23219e84056a088a4808da38d3c92c79018be93

Patch Set 1 : Merge branch 'fix_dcheck' into fix_deep_link #

Patch Set 2 : Merge branch 'fix_dcheck' into fix_deep_link #

Patch Set 3 : Merge branch 'master' into fix_deep_link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
pkotwicz
Xi can you please take a look?
3 years, 8 months ago (2017-04-04 00:08:38 UTC) #2
Xi Han
lgtm!
3 years, 8 months ago (2017-04-04 14:24:46 UTC) #4
pkotwicz
Dominick for OWNERS
3 years, 8 months ago (2017-04-04 15:14:03 UTC) #6
dominickn
lgtm
3 years, 8 months ago (2017-04-05 00:37:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796773002/40001
3 years, 8 months ago (2017-04-05 03:53:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/241988)
3 years, 8 months ago (2017-04-05 04:52:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796773002/60001
3 years, 8 months ago (2017-04-06 19:25:23 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 20:52:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c23219e84056a088a4808da38d3c...

Powered by Google App Engine
This is Rietveld 408576698