Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java

Issue 2796773002: [Android WebAPKs] Force navigation on launch by default (Closed)
Patch Set: Merge branch 'master' into fix_deep_link Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
index 286c0012318e66a064d7c6851522401f7a9c8587..41bbb50df489f4275cb7279687e03dd347ca433a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java
@@ -56,8 +56,12 @@ public class WebApkInfo extends WebappInfo {
String url = urlFromIntent(intent);
int source = sourceFromIntent(intent);
+
+ // Force navigation if the extra is not specified to avoid breaking deep linking for old
+ // WebAPKs which don't specify the {@link WebApkConstants#EXTRA_WEBAPK_FORCE_NAVIGATION}
+ // intent extra.
boolean forceNavigation = IntentUtils.safeGetBooleanExtra(
- intent, WebApkConstants.EXTRA_WEBAPK_FORCE_NAVIGATION, false);
+ intent, WebApkConstants.EXTRA_WEBAPK_FORCE_NAVIGATION, true);
return create(webApkPackageName, url, source, forceNavigation);
}
« no previous file with comments | « no previous file | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698