Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2796693002: Minor pre-MD cleanups in chromeos network UI code (just renames). (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor pre-MD cleanups in chromeos network UI code (just renames). BUG=686251 Review-Url: https://codereview.chromium.org/2796693002 Cr-Commit-Position: refs/heads/master@{#461614} Committed: https://chromium.googlesource.com/chromium/src/+/aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -836 lines) Patch
M ash/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/system/chromeos/network/network_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/common/system/chromeos/network/network_list.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/common/system/chromeos/network/network_list_md.h View 1 chunk +0 lines, -140 lines 0 comments Download
D ash/common/system/chromeos/network/network_list_md.cc View 1 1 chunk +0 lines, -683 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Evan Stade
3 years, 8 months ago (2017-04-03 19:26:30 UTC) #3
tdanderson
LGTM. You may need to rebase in light of https://codereview.chromium.org/2789253002 which landed very recently (sorry).
3 years, 8 months ago (2017-04-03 22:20:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796693002/20001
3 years, 8 months ago (2017-04-04 00:54:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796693002/20001
3 years, 8 months ago (2017-04-04 01:03:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796693002/20001
3 years, 8 months ago (2017-04-04 01:04:25 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 02:18:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aa1c0022137ae8c92a1c5dc786c1...

Powered by Google App Engine
This is Rietveld 408576698