[Ash] Remove HoverHighlightView::hover()

[Ash] Remove HoverHighlightView::hover()

As part of the material design rework of the system menu,
the |hover_| member of HoverHighlightView was no longer
being updated. However both the network submenu and the
VPN submenu were accessing this member (via hover()) to
keep currently-hovered menu rows visible during an update
to the network/VPN list. Remove hover() and instead call
View::IsMouseHovered() at its call sites instead to
restore the intended behavior.

BUG=686345
TEST=manual

Review-Url: https://codereview.chromium.org/2789253002
Cr-Commit-Position: refs/heads/master@{#461543}
Committed: https://chromium.googlesource.com/chromium/src/+/5360eea373d896d8916087952ace99ed2a7ff05a

[tdanderson, 2017-04-03 20:43:43]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2017-04-03 20:44:22]

tdanderson@chromium.org changed reviewers:
+ stevenjb@chromium.org

[tdanderson, 2017-04-03 20:44:22]

stevenjb@, can you please take a look?

[commit-bot: I haz the power, 2017-04-03 20:44:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-04-03 20:51:44]

lgtm

[tdanderson, 2017-04-03 21:00:23]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2017-04-03 21:00:26]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2017-04-03 21:00:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:17:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491253226105660, "parent_rev":
"5f8b467781b1b08d611e1d05f31c10dee5538edb", "commit_rev":
"5360eea373d896d8916087952ace99ed2a7ff05a"}

[commit-bot: I haz the power, 2017-04-03 21:18:24]

Description was changed from

==========
[Ash] Remove HoverHighlightView::hover()

As part of the material design rework of the system menu,
the |hover_| member of HoverHighlightView was no longer
being updated. However both the network submenu and the
VPN submenu were accessing this member (via hover()) to
keep currently-hovered menu rows visible during an update
to the network/VPN list. Remove hover() and instead call
View::IsMouseHovered() at its call sites instead to
restore the intended behavior.

BUG=686345
TEST=manual
==========

to

==========
[Ash] Remove HoverHighlightView::hover()

As part of the material design rework of the system menu,
the |hover_| member of HoverHighlightView was no longer
being updated. However both the network submenu and the
VPN submenu were accessing this member (via hover()) to
keep currently-hovered menu rows visible during an update
to the network/VPN list. Remove hover() and instead call
View::IsMouseHovered() at its call sites instead to
restore the intended behavior.

BUG=686345
TEST=manual

Review-Url: https://codereview.chromium.org/2789253002
Cr-Commit-Position: refs/heads/master@{#461543}
Committed:
https://chromium.googlesource.com/chromium/src/+/5360eea373d896d8916087952ace...
==========

[commit-bot: I haz the power, 2017-04-03 21:18:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5360eea373d896d8916087952ace...