Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2796663002: Revert of [WebUI] Tweak action-link's .no-outline removal behavior on blur. (Closed)

Created:
3 years, 8 months ago by huangs
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [WebUI] Tweak action-link's .no-outline removal behavior on blur. (patchset #1 id:1 of https://codereview.chromium.org/2744893002/ ) Reason for revert: This fixes http://crbug.com/698270 but leads to http://crbug.com/701268, which seems more serious. Original issue's description: > [WebUI] Tweak action-link's .no-outline behavior on blur. > > To emulate <a> :focus styling, action-link adds .no-outline on > mousedown, but removes .no-outline on blur. This indiscreminate removal > disregard the edge case where source of blur is from outside the web > page (e.g., Alt-Tab). This CL add an extra check to remedy this. > > BUG=698270 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2744893002 > Cr-Commit-Position: refs/heads/master@{#456159} > Committed: https://chromium.googlesource.com/chromium/src/+/d5fc002027195691680b127e58458d1b2b86d5a1 TBR=dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=698270 Review-Url: https://codereview.chromium.org/2796663002 Cr-Commit-Position: refs/heads/master@{#461508} Committed: https://chromium.googlesource.com/chromium/src/+/57a47c3f25ab6992306269e41e47374a59786f0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/webui/resources/js/action_link.js View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
huangs
Created Revert of [WebUI] Tweak action-link's .no-outline removal behavior on blur.
3 years, 8 months ago (2017-04-03 17:11:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796663002/1
3 years, 8 months ago (2017-04-03 17:14:23 UTC) #3
Dan Beam
lgtm
3 years, 8 months ago (2017-04-03 17:38:00 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 19:48:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57a47c3f25ab6992306269e41e47...

Powered by Google App Engine
This is Rietveld 408576698