Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2744893002: [WebUI] Tweak action-link's .no-outline removal behavior on blur. (Closed)

Created:
3 years, 9 months ago by huangs
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebUI] Tweak action-link's .no-outline behavior on blur. To emulate <a> :focus styling, action-link adds .no-outline on mousedown, but removes .no-outline on blur. This indiscreminate removal disregard the edge case where source of blur is from outside the web page (e.g., Alt-Tab). This CL add an extra check to remedy this. BUG=698270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2744893002 Cr-Commit-Position: refs/heads/master@{#456159} Committed: https://chromium.googlesource.com/chromium/src/+/d5fc002027195691680b127e58458d1b2b86d5a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/webui/resources/js/action_link.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
huangs
PTAL. Thanks!
3 years, 9 months ago (2017-03-10 20:01:29 UTC) #4
Dan Beam
aight, let's give this a shot. lgtm
3 years, 9 months ago (2017-03-10 20:10:50 UTC) #5
huangs
Thanks. Committing!
3 years, 9 months ago (2017-03-10 20:12:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744893002/1
3 years, 9 months ago (2017-03-10 20:13:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d5fc002027195691680b127e58458d1b2b86d5a1
3 years, 9 months ago (2017-03-10 21:06:54 UTC) #11
huangs
3 years, 8 months ago (2017-04-03 17:11:37 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2796663002/ by huangs@chromium.org.

The reason for reverting is: This fixes http://crbug.com/698270 but leads to
http://crbug.com/701268, which seems more serious..

Powered by Google App Engine
This is Rietveld 408576698