Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2796653003: Move ScriptState::forWorld/ScriptState::forMainWorld (Part 2) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, Rik, caseq+blink_chromium.org, chasej+watch_chromium.org, chromium-reviews, cmumford, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, eae+blinkwatch, Eric Willigers, falken+watch_chromium.org, fuzzing_chromium.org, hongchan, horo+watch_chromium.org, iclelland+watch_chromuim.org, jbroman+watch_chromium.org, jchaffraix+rendering, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, Justin Novosad, kinuko+watch, kinuko+serviceworker, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, michaeln, nhiroki, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, Raymond Toy, serviceworker-reviews, shans, shimazu+serviceworker_chromium.org, sof, szager+layoutwatch_chromium.org, tzik, webcomponents-bugzilla_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::forWorld/ScriptState::forMainWorld (Part 2) This CL changes all call sites for ScriptState::forMainWorld to use toScriptStateforMainWorld, which was added in http://crrev.com/2794023002. BUG=682322 Review-Url: https://codereview.chromium.org/2796653003 Cr-Commit-Position: refs/heads/master@{#462060} Committed: https://chromium.googlesource.com/chromium/src/+/5b50cd0bc4e0f5bca1f97593325751b5b6db5c52

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -57 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolverTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 7 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DevToolsHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusControllerTest.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamBytesConsumerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 6 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
adithyas
3 years, 8 months ago (2017-04-04 19:55:57 UTC) #7
jbroman
lgtm
3 years, 8 months ago (2017-04-04 20:29:07 UTC) #9
haraken
LGTM
3 years, 8 months ago (2017-04-05 00:33:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796653003/20001
3 years, 8 months ago (2017-04-05 13:58:34 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 14:05:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b50cd0bc4e0f5bca1f975933257...

Powered by Google App Engine
This is Rietveld 408576698