third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 2796653003: Move ScriptState::forWorld/ScriptState::forMainWorld (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 2796653003: Move ScriptState::forWorld/ScriptState::forMainWorld (Part 2) (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index 615342cc3ed0d85236e8aa889b122349677cadf7..490b93a33479da025dd7fa200acc788e85e6ca17 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -12,6 +12,7 @@

#include "bindings/core/v8/ScriptFunction.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptState.h"

+#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8DOMException.h"

#include "bindings/core/v8/V8GCController.h"

#include "core/dom/DOMException.h"

@@ -157,7 +158,7 @@ class ServiceWorkerContainerTest : public ::testing::Test {

}

v8::Isolate* isolate() { return v8::Isolate::GetCurrent(); }

ScriptState* getScriptState() {

- return ScriptState::forMainWorld(m_page->document().frame());

+ return toScriptStateForMainWorld(m_page->document().frame());

}

void provide(std::unique_ptr<WebServiceWorkerProvider> provider) {