Disable atrace in TBMv2 media benchmarks

Disable atrace in TBMv2 media benchmarks

Remove enable_atrace_trace option in TBMv2 based media benchmarks,
as it is causing errors on some Android devices (due to bug 710920).

BUG=707286, 710920
Review-Url: https://codereview.chromium.org/2796623003
Cr-Commit-Position: refs/heads/master@{#464210}
Committed: https://chromium.googlesource.com/chromium/src/+/97a6fea550e9d2fcd81649cffbb0de8b4750af9a

[johnchen, 2017-04-12 17:20:54]

johnchen@chromium.org changed reviewers:
+ crouleau@chromium.org, nednguyen@google.com

[johnchen, 2017-04-12 17:20:54]

Ned & Caleb,

Please review this CL, which disables atrace in
media.android.tough_video_cases_tbmv2, since it causes errors on various Android
devices, and doesn't contribute to the metrics we collect. Disabling it allows
us to collect data on a wider range of Android devices.

Created separate bug 710920 for fixing atrace.

[nednguyen, 2017-04-12 17:22:53]

On 2017/04/12 17:20:54, johnchen wrote:
> Ned & Caleb,
> 
> Please review this CL, which disables atrace in
> media.android.tough_video_cases_tbmv2, since it causes errors on various
Android
> devices, and doesn't contribute to the metrics we collect. Disabling it allows
> us to collect data on a wider range of Android devices.
> 
> Created separate bug 710920 for fixing atrace.

atrace is good for understanding all the things that are going on at the system
level. What was the error?

[johnchen, 2017-04-12 17:25:50]

On 2017/04/12 17:22:53, nednguyen wrote:
> On 2017/04/12 17:20:54, johnchen wrote:
> > Ned & Caleb,
> > 
> > Please review this CL, which disables atrace in
> > media.android.tough_video_cases_tbmv2, since it causes errors on various
> Android
> > devices, and doesn't contribute to the metrics we collect. Disabling it
allows
> > us to collect data on a wider range of Android devices.
> > 
> > Created separate bug 710920 for fixing atrace.
> 
> atrace is good for understanding all the things that are going on at the
system
> level. What was the error?

The error message is "printf: not found". The tracing agent tries to run shell
command printf, but apparently this command isn't available on some Android
devices.

[sullivan, 2017-04-12 17:27:40]

On 2017/04/12 17:25:50, johnchen wrote:
> On 2017/04/12 17:22:53, nednguyen wrote:
> > On 2017/04/12 17:20:54, johnchen wrote:
> > > Ned & Caleb,
> > > 
> > > Please review this CL, which disables atrace in
> > > media.android.tough_video_cases_tbmv2, since it causes errors on various
> > Android
> > > devices, and doesn't contribute to the metrics we collect. Disabling it
> allows
> > > us to collect data on a wider range of Android devices.
> > > 
> > > Created separate bug 710920 for fixing atrace.
> > 
> > atrace is good for understanding all the things that are going on at the
> system
> > level. What was the error?
> 
> The error message is "printf: not found". The tracing agent tries to run shell
> command printf, but apparently this command isn't available on some Android
> devices.

Should probably reference crbug.com/710920 in the CL description to help clarify
the reasoning for this.

[johnchen, 2017-04-12 17:30:34]

Description was changed from

==========
Disable atrace in TBMv2 media benchmarks

Remove enable_atrace_trace option in TBMv2 based media benchmarks,
as it is causing errors on some Android devices.

BUG=707286
==========

to

==========
Disable atrace in TBMv2 media benchmarks

Remove enable_atrace_trace option in TBMv2 based media benchmarks,
as it is causing errors on some Android devices (due to bug 710920).

BUG=707286, 710920
==========

[johnchen, 2017-04-12 17:31:17]

On 2017/04/12 17:27:40, sullivan wrote:
> On 2017/04/12 17:25:50, johnchen wrote:
> > On 2017/04/12 17:22:53, nednguyen wrote:
> > > On 2017/04/12 17:20:54, johnchen wrote:
> > > > Ned & Caleb,
> > > > 
> > > > Please review this CL, which disables atrace in
> > > > media.android.tough_video_cases_tbmv2, since it causes errors on various
> > > Android
> > > > devices, and doesn't contribute to the metrics we collect. Disabling it
> > allows
> > > > us to collect data on a wider range of Android devices.
> > > > 
> > > > Created separate bug 710920 for fixing atrace.
> > > 
> > > atrace is good for understanding all the things that are going on at the
> > system
> > > level. What was the error?
> > 
> > The error message is "printf: not found". The tracing agent tries to run
shell
> > command printf, but apparently this command isn't available on some Android
> > devices.
> 
> Should probably reference crbug.com/710920 in the CL description to help
clarify
> the reasoning for this.

Added bug 710920 to CL description.

[nednguyen, 2017-04-12 17:33:16]

lgtm

[CalebRouleau, 2017-04-12 18:03:37]

LGTM

[johnchen, 2017-04-12 21:01:52]

The CQ bit was checked by johnchen@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:03:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:49:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492030912010060, "parent_rev":
"19860c1f69377affc0e8fae4fdece5572c8ed678", "commit_rev":
"97a6fea550e9d2fcd81649cffbb0de8b4750af9a"}

[commit-bot: I haz the power, 2017-04-12 23:51:13]

Description was changed from

==========
Disable atrace in TBMv2 media benchmarks

Remove enable_atrace_trace option in TBMv2 based media benchmarks,
as it is causing errors on some Android devices (due to bug 710920).

BUG=707286, 710920
==========

to

==========
Disable atrace in TBMv2 media benchmarks

Remove enable_atrace_trace option in TBMv2 based media benchmarks,
as it is causing errors on some Android devices (due to bug 710920).

BUG=707286, 710920

Review-Url: https://codereview.chromium.org/2796623003
Cr-Commit-Position: refs/heads/master@{#464210}
Committed:
https://chromium.googlesource.com/chromium/src/+/97a6fea550e9d2fcd81649cffbb0...
==========

[commit-bot: I haz the power, 2017-04-12 23:51:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97a6fea550e9d2fcd81649cffbb0...