Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: tools/perf/benchmarks/media.py

Issue 2796623003: Disable atrace in TBMv2 media benchmarks (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index 06b1d8b748922aa82340923b088efabdd6d0e818..f37ce44021b758f3313ac0385402b297fbfa62d3 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -66,8 +66,6 @@ class _MediaTBMv2Benchmark(perf_benchmark.PerfBenchmark):
category_filter.AddIncludedCategory('rail')
options = timeline_based_measurement.Options(category_filter)
- options.config.enable_atrace_trace = True
- options.config.atrace_config.categories = ['sched']
options.config.enable_battor_trace = True
options.SetTimelineBasedMetrics(['powerMetric', 'cpuTimeMetric'])
return options
@@ -142,10 +140,7 @@ class MediaAndroidToughVideoCasesTBMv2(_MediaTBMv2Benchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- # crbug.com/707286: This benchmark is having issues with devices other
- # than Nexus 5X. Disabling on those devices until we figure out the cause.
- return (cls.IsSvelte(possible_browser) or
- possible_browser.platform.GetDeviceTypeName() != 'Nexus 5X')
+ return cls.IsSvelte(possible_browser)
@classmethod
def Name(cls):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698