Split TextCheckerClientImpl off SpellCheckerClientImpl

Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.
Full design: https://goo.gl/VfCENk

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2796473002
Cr-Commit-Position: refs/heads/master@{#461520}
Committed: https://chromium.googlesource.com/chromium/src/+/d734458df440a682fd4c32c80153906622188091

[Xiaocheng, 2017-03-31 23:18:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 23:18:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-03-31 23:21:44]

Description was changed from

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

BUG=638361
==========

to

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes
==========

[Xiaocheng, 2017-03-31 23:22:37]

xiaochengh@chromium.org changed reviewers:
+ dcheng@chromium.org

[Xiaocheng, 2017-03-31 23:22:38]

PTAL.

[Xiaocheng, 2017-04-01 00:07:13]

Description was changed from

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes
==========

to

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.
Full design: https://goo.gl/VfCENk

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes
==========

[Xiaocheng, 2017-04-01 00:07:43]

Description was changed from

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.
Full design: https://goo.gl/VfCENk

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes
==========

to

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.
Full design: https://goo.gl/VfCENk

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-04-01 01:37:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 01:37:53]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xiaocheng, 2017-04-01 01:47:52]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-01 01:48:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-01 02:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-01 02:33:47]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-04-02 05:28:25]

LGTM

https://codereview.chromium.org/2796473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/SpellCheckerClientImpl.h (right):

https://codereview.chromium.org/2796473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/SpellCheckerClientImpl.h:43: explicit
SpellCheckerClientImpl(WebViewImpl*, TextCheckerClient*);
Nit: remove explicit

[Xiaocheng, 2017-04-03 17:49:24]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-04-03 17:49:25]

Thanks for the review!

https://codereview.chromium.org/2796473002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/SpellCheckerClientImpl.h (right):

https://codereview.chromium.org/2796473002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/SpellCheckerClientImpl.h:43: explicit
SpellCheckerClientImpl(WebViewImpl*, TextCheckerClient*);
On 2017/04/02 at 05:28:25, dcheng wrote:
> Nit: remove explicit

Done.

[Xiaocheng, 2017-04-03 17:49:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2796473002/#ps40001
(title: "Remove explicit")

[commit-bot: I haz the power, 2017-04-03 17:50:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 20:18:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491241764251720,
"parent_rev": "b0723e898f49990ebb0df94b75db7693f82a79f5", "commit_rev":
"d734458df440a682fd4c32c80153906622188091"}

[commit-bot: I haz the power, 2017-04-03 20:18:54]

Description was changed from

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.
Full design: https://goo.gl/VfCENk

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes
==========

to

==========
Split TextCheckerClientImpl off SpellCheckerClientImpl

This is Patch 1 of 5 for making SpellCheckProvider a
RenderFrameObserver, so that spellcheck can work in OOPIF.
Full design: https://goo.gl/VfCENk

This patch splits the implementation of TextCheckerClient off
SpellCheckerClientImpl into a new class, TextCheckerClientImpl.
The new class is still owned by WebViewImpl and weak referenced
by SpellCheckerClientImpl, so that there is no visible change
outside web/.

BUG=638361
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2796473002
Cr-Commit-Position: refs/heads/master@{#461520}
Committed:
https://chromium.googlesource.com/chromium/src/+/d734458df440a682fd4c32c80153...
==========

[commit-bot: I haz the power, 2017-04-03 20:18:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d734458df440a682fd4c32c80153...