Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: third_party/WebKit/Source/web/SpellCheckerClientImpl.h

Issue 2796473002: Split TextCheckerClientImpl off SpellCheckerClientImpl (Closed)
Patch Set: Remove explicit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/BUILD.gn ('k') | third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/SpellCheckerClientImpl.h
diff --git a/third_party/WebKit/Source/web/SpellCheckerClientImpl.h b/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
index 78949f3023094210ce7251df582f4400654bb1dd..ca4f090c3484741cf9dfef51204b92cb6d570e0e 100644
--- a/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
+++ b/third_party/WebKit/Source/web/SpellCheckerClientImpl.h
@@ -32,32 +32,25 @@
#define SpellCheckerClientImpl_h
#include "core/page/SpellCheckerClient.h"
-#include "platform/heap/Handle.h"
-#include "platform/text/TextCheckerClient.h"
namespace blink {
+class TextCheckerClient;
class WebViewImpl;
-class SpellCheckerClientImpl final : public SpellCheckerClient,
- public TextCheckerClient {
+class SpellCheckerClientImpl final : public SpellCheckerClient {
public:
- explicit SpellCheckerClientImpl(WebViewImpl*);
+ explicit SpellCheckerClientImpl(WebViewImpl*, TextCheckerClient*);
~SpellCheckerClientImpl() override;
bool isSpellCheckingEnabled() override;
void toggleSpellCheckingEnabled() override;
- void checkSpellingOfString(const String&,
- int* misspellingLocation,
- int* misspellingLength) override;
void updateSpellingUIWithMisspelledWord(const String&) override;
void showSpellingUI(bool show) override;
bool spellingUIIsShowing() override;
- void requestCheckingOfString(TextCheckingRequest*) override;
- void cancelAllPendingRequests() override;
- TextCheckerClient& textChecker() override { return *this; }
+ TextCheckerClient& textChecker() override { return *m_textCheckerClient; }
private:
// Returns whether or not the focused control needs spell-checking.
@@ -70,6 +63,7 @@ class SpellCheckerClientImpl final : public SpellCheckerClient,
bool shouldSpellcheckByDefault();
WebViewImpl* m_webView;
+ TextCheckerClient* m_textCheckerClient;
// This flag is set to false if spell check for this editor is manually
// turned off. The default setting is SpellCheckAutomatic.
« no previous file with comments | « third_party/WebKit/Source/web/BUILD.gn ('k') | third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698