Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: components/favicon/core/favicon_service_impl.cc

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_service_impl.h ('k') | components/favicon/core/large_icon_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_service_impl.cc
diff --git a/components/favicon/core/favicon_service_impl.cc b/components/favicon/core/favicon_service_impl.cc
index 98557b2476647f77240bab105c6987c41386edce..a8c1c236f9cc90c535d0d7d7733a158580ac60e7 100644
--- a/components/favicon/core/favicon_service_impl.cc
+++ b/components/favicon/core/favicon_service_impl.cc
@@ -149,8 +149,6 @@ base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetRawFaviconForPageURL(
base::CancelableTaskTracker::TaskId
FaviconServiceImpl::GetLargestRawFaviconForPageURL(
const GURL& page_url,
- const std::vector<int>& icon_types,
- int minimum_size_in_pixels,
const favicon_base::FaviconRawBitmapCallback& callback,
base::CancelableTaskTracker* tracker) {
TRACE_EVENT0("browser", "FaviconServiceImpl::GetLargestRawFaviconForPageURL");
@@ -163,8 +161,7 @@ FaviconServiceImpl::GetLargestRawFaviconForPageURL(
return favicon_client_->GetFaviconForNativeApplicationURL(
page_url, desired_sizes_in_pixel, favicon_results_callback, tracker);
}
- return history_service_->GetLargestFaviconForURL(
- page_url, icon_types, minimum_size_in_pixels, callback, tracker);
+ return history_service_->GetLargestFaviconForURL(page_url, callback, tracker);
}
base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFaviconForPageURL(
« no previous file with comments | « components/favicon/core/favicon_service_impl.h ('k') | components/favicon/core/large_icon_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698