components/favicon/core/favicon_service_impl.h - Issue 2796343003: Remove preferences among favicon types when choosing large icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_service_impl.h

Issue 2796343003: Remove preferences among favicon types when choosing large icons

Patch Set: Rebased. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_service_impl.h

diff --git a/components/favicon/core/favicon_service_impl.h b/components/favicon/core/favicon_service_impl.h

index d7e5c308823cf1e531b1382c1f95a6ef7dddee17..56a0e390e3b6c8d6d21654a20d550701b2ab885d 100644

--- a/components/favicon/core/favicon_service_impl.h

+++ b/components/favicon/core/favicon_service_impl.h

@@ -69,8 +69,6 @@ class FaviconServiceImpl : public FaviconService {

base::CancelableTaskTracker* tracker) override;

base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL(

const GURL& page_url,

- const std::vector<int>& icon_types,

- int minimum_size_in_pixels,

const favicon_base::FaviconRawBitmapCallback& callback,

base::CancelableTaskTracker* tracker) override;

base::CancelableTaskTracker::TaskId GetFaviconForPageURL(