Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: components/favicon/core/favicon_service_impl.cc

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/favicon/core/favicon_service_impl.h" 5 #include "components/favicon/core/favicon_service_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <cmath> 8 #include <cmath>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 page_url, icon_types, desired_sizes_in_pixel, 142 page_url, icon_types, desired_sizes_in_pixel,
143 base::Bind( 143 base::Bind(
144 &FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults, 144 &FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults,
145 base::Unretained(this), callback, desired_size_in_pixel), 145 base::Unretained(this), callback, desired_size_in_pixel),
146 tracker); 146 tracker);
147 } 147 }
148 148
149 base::CancelableTaskTracker::TaskId 149 base::CancelableTaskTracker::TaskId
150 FaviconServiceImpl::GetLargestRawFaviconForPageURL( 150 FaviconServiceImpl::GetLargestRawFaviconForPageURL(
151 const GURL& page_url, 151 const GURL& page_url,
152 const std::vector<int>& icon_types,
153 int minimum_size_in_pixels,
154 const favicon_base::FaviconRawBitmapCallback& callback, 152 const favicon_base::FaviconRawBitmapCallback& callback,
155 base::CancelableTaskTracker* tracker) { 153 base::CancelableTaskTracker* tracker) {
156 TRACE_EVENT0("browser", "FaviconServiceImpl::GetLargestRawFaviconForPageURL"); 154 TRACE_EVENT0("browser", "FaviconServiceImpl::GetLargestRawFaviconForPageURL");
157 favicon_base::FaviconResultsCallback favicon_results_callback = base::Bind( 155 favicon_base::FaviconResultsCallback favicon_results_callback = base::Bind(
158 &FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults, 156 &FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults,
159 base::Unretained(this), callback, 0); 157 base::Unretained(this), callback, 0);
160 if (favicon_client_ && favicon_client_->IsNativeApplicationURL(page_url)) { 158 if (favicon_client_ && favicon_client_->IsNativeApplicationURL(page_url)) {
161 std::vector<int> desired_sizes_in_pixel; 159 std::vector<int> desired_sizes_in_pixel;
162 desired_sizes_in_pixel.push_back(0); 160 desired_sizes_in_pixel.push_back(0);
163 return favicon_client_->GetFaviconForNativeApplicationURL( 161 return favicon_client_->GetFaviconForNativeApplicationURL(
164 page_url, desired_sizes_in_pixel, favicon_results_callback, tracker); 162 page_url, desired_sizes_in_pixel, favicon_results_callback, tracker);
165 } 163 }
166 return history_service_->GetLargestFaviconForURL( 164 return history_service_->GetLargestFaviconForURL(page_url, callback, tracker);
167 page_url, icon_types, minimum_size_in_pixels, callback, tracker);
168 } 165 }
169 166
170 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFaviconForPageURL( 167 base::CancelableTaskTracker::TaskId FaviconServiceImpl::GetFaviconForPageURL(
171 const GURL& page_url, 168 const GURL& page_url,
172 int icon_types, 169 int icon_types,
173 int desired_size_in_dip, 170 int desired_size_in_dip,
174 const favicon_base::FaviconResultsCallback& callback, 171 const favicon_base::FaviconResultsCallback& callback,
175 base::CancelableTaskTracker* tracker) { 172 base::CancelableTaskTracker* tracker) {
176 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconForPageURL"); 173 TRACE_EVENT0("browser", "FaviconServiceImpl::GetFaviconForPageURL");
177 return GetFaviconForPageURLImpl( 174 return GetFaviconForPageURLImpl(
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 const std::vector<favicon_base::FaviconRawBitmapResult>& 298 const std::vector<favicon_base::FaviconRawBitmapResult>&
302 favicon_bitmap_results) { 299 favicon_bitmap_results) {
303 TRACE_EVENT0( 300 TRACE_EVENT0(
304 "browser", 301 "browser",
305 "FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults"); 302 "FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults");
306 callback.Run( 303 callback.Run(
307 ResizeFaviconBitmapResult(favicon_bitmap_results, desired_size_in_pixel)); 304 ResizeFaviconBitmapResult(favicon_bitmap_results, desired_size_in_pixel));
308 } 305 }
309 306
310 } // namespace favicon 307 } // namespace favicon
OLDNEW
« no previous file with comments | « components/favicon/core/favicon_service_impl.h ('k') | components/favicon/core/large_icon_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698