Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2796303009: [Omaha] Catch SecurityExceptions (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Omaha] Catch SecurityExceptions These are getting thrown, but don't make any sense because we explicitly ask for INTERNET permission. Guessing rooted devices aren't playing nice with our manifests. BUG=708908 TBR=nyquist Original-Review-Url: https://codereview.chromium.org/2805063002 Original-Cr-Commit-Position: refs/heads/master@{#462726} Review-Url: https://codereview.chromium.org/2796303009 . Cr-Commit-Position: refs/branch-heads/3029@{#627} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/3d91a94fa7bc138abbf41f4fa2b362f2b35f6f6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaBase.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (3 generated)
gone
3 years, 8 months ago (2017-04-07 18:20:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d91a94fa7bc138abbf41f4fa2b362f2b35f6f6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698