Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2805063002: [Omaha] Catch SecurityExceptions (Closed)

Created:
3 years, 8 months ago by gone
Modified:
3 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Omaha] Catch SecurityExceptions These are getting thrown, but don't make any sense because we explicitly ask for INTERNET permission. Guessing rooted devices aren't playing nice with our manifests. BUG=708908 Review-Url: https://codereview.chromium.org/2805063002 Cr-Commit-Position: refs/heads/master@{#462726} Committed: https://chromium.googlesource.com/chromium/src/+/dc59bccacdd6aedddc578d80025a78910916bc38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omaha/OmahaBase.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
gone
3 years, 8 months ago (2017-04-06 18:41:03 UTC) #2
nyquist
lgtm
3 years, 8 months ago (2017-04-06 23:19:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805063002/1
3 years, 8 months ago (2017-04-06 23:31:30 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:13:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc59bccacdd6aedddc578d80025a...

Powered by Google App Engine
This is Rietveld 408576698