Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2796303003: Revert of Simplify MetricsWebContentsObserver::OnTimingUpdated (patchset #1 id:1 of https://coderev… (Closed)

Created:
3 years, 8 months ago by nasko
Modified:
3 years, 8 months ago
Reviewers:
nasko, Charlie Harrison
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3063
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify MetricsWebContentsObserver::OnTimingUpdated (patchset #1 id:1 of https://codereview.chromium.org/2795283003/ ) Reason for revert: Address bug 708468 Original issue's description: > Simplify MetricsWebContentsObserver::OnTimingUpdated > > The check for whether a frame has navigated away is a bit more complex > than needed and uses RenderViewHost, which has been deprecated for a > while. This CL moves the child frame check first, which allows the code > to perform a simpler check using the WebContents::GetMainFrame(). > > BUG= > > Review-Url: https://codereview.chromium.org/2795283003 > Cr-Commit-Position: refs/heads/master@{#461875} > Committed: https://chromium.googlesource.com/chromium/src/+/0735c4618fe9c05775cf55be073f7fcb4c2e75ac TBR=csharrison@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2802693002 Cr-Commit-Position: refs/heads/master@{#462048} (cherry picked from commit 253fe7d912b4e16fd56c6ce0a68906d0f1a376e2) Review-Url: https://codereview.chromium.org/2796303003 . Cr-Commit-Position: refs/branch-heads/3063@{#3} Cr-Branched-From: eb509f59b8e9f31569d0dad0d90d8f755291d497-refs/heads/master@{#461928} Committed: https://chromium.googlesource.com/chromium/src/+/840a2f62d003201847311862c87fe49b3a9e548d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
nasko
Committed patchset #1 (id:1) manually as 840a2f62d003201847311862c87fe49b3a9e548d.
3 years, 8 months ago (2017-04-05 17:44:13 UTC) #2
Charlie Harrison
3 years, 8 months ago (2017-04-05 17:45:55 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698