Chromium Code Reviews
DescriptionRevert of Simplify MetricsWebContentsObserver::OnTimingUpdated (patchset #1 id:1 of https://codereview.chromium.org/2795283003/ )
Reason for revert:
Address bug 708468
Original issue's description:
> Simplify MetricsWebContentsObserver::OnTimingUpdated
>
> The check for whether a frame has navigated away is a bit more complex
> than needed and uses RenderViewHost, which has been deprecated for a
> while. This CL moves the child frame check first, which allows the code
> to perform a simpler check using the WebContents::GetMainFrame().
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2795283003
> Cr-Commit-Position: refs/heads/master@{#461875}
> Committed: https://chromium.googlesource.com/chromium/src/+/0735c4618fe9c05775cf55be073f7fcb4c2e75ac
TBR=csharrison@chromium.org,nasko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2802693002
Cr-Commit-Position: refs/heads/master@{#462048}
(cherry picked from commit 253fe7d912b4e16fd56c6ce0a68906d0f1a376e2)
Review-Url: https://codereview.chromium.org/2796303003 .
Cr-Commit-Position: refs/branch-heads/3063@{#3}
Cr-Branched-From: eb509f59b8e9f31569d0dad0d90d8f755291d497-refs/heads/master@{#461928}
Committed: https://chromium.googlesource.com/chromium/src/+/840a2f62d003201847311862c87fe49b3a9e548d
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
|||||||||||||||||||