Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2802693002: Revert of Simplify MetricsWebContentsObserver::OnTimingUpdated (Closed)

Created:
3 years, 8 months ago by Bryan McQuade
Modified:
3 years, 8 months ago
Reviewers:
nasko, Charlie Harrison
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Simplify MetricsWebContentsObserver::OnTimingUpdated (patchset #1 id:1 of https://codereview.chromium.org/2795283003/ ) Reason for revert: Address bug 708468 Original issue's description: > Simplify MetricsWebContentsObserver::OnTimingUpdated > > The check for whether a frame has navigated away is a bit more complex > than needed and uses RenderViewHost, which has been deprecated for a > while. This CL moves the child frame check first, which allows the code > to perform a simpler check using the WebContents::GetMainFrame(). > > BUG= > > Review-Url: https://codereview.chromium.org/2795283003 > Cr-Commit-Position: refs/heads/master@{#461875} > Committed: https://chromium.googlesource.com/chromium/src/+/0735c4618fe9c05775cf55be073f7fcb4c2e75ac TBR=csharrison@chromium.org,nasko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2802693002 Cr-Commit-Position: refs/heads/master@{#462048} Committed: https://chromium.googlesource.com/chromium/src/+/253fe7d912b4e16fd56c6ce0a68906d0f1a376e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M chrome/browser/page_load_metrics/metrics_web_contents_observer.cc View 2 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bryan McQuade
Created Revert of Simplify MetricsWebContentsObserver::OnTimingUpdated
3 years, 8 months ago (2017-04-05 13:02:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802693002/1
3 years, 8 months ago (2017-04-05 13:02:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/253fe7d912b4e16fd56c6ce0a68906d0f1a376e2
3 years, 8 months ago (2017-04-05 13:03:55 UTC) #6
Charlie Harrison
3 years, 8 months ago (2017-04-05 13:17:54 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698