Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2796123004: Use SameDocument term in subresource_filter_browsertest. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
Reviewers:
melandory
CC:
chromium-reviews, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SameDocument term in subresource_filter_browsertest. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2796123004 Cr-Commit-Position: refs/heads/master@{#462083} Committed: https://chromium.googlesource.com/chromium/src/+/cfaf497e50484a20c662f4bb57e3ce2c67463ed2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/subresource_filter/subresource_filter_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-05 00:24:46 UTC) #6
melandory
On 2017/04/05 00:24:46, Eugene But wrote: lgtm
3 years, 8 months ago (2017-04-05 08:12:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796123004/1
3 years, 8 months ago (2017-04-05 15:33:25 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 15:45:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfaf497e50484a20c662f4bb57e3...

Powered by Google App Engine
This is Rietveld 408576698