Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: chrome/browser/subresource_filter/subresource_filter_browsertest.cc

Issue 2796123004: Use SameDocument term in subresource_filter_browsertest. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/subresource_filter/subresource_filter_browsertest.cc
diff --git a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
index 974cae9a8d4f2770fce5a58c79d4ce31412616b1..3698ec2bf1a3c4f7f6a3d330824e2b3d9354e871 100644
--- a/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
+++ b/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
@@ -511,9 +511,9 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterListBrowserTest, MainFrameActivation) {
#endif
// There should be no document-level de-/reactivation happening on the renderer
-// side as a result of an in-page navigation.
+// side as a result of a same document navigation.
IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,
- DocumentActivationOutlivesSamePageNavigation) {
+ DocumentActivationOutlivesSameDocumentNavigation) {
GURL url(GetTestUrl("subresource_filter/frame_with_delayed_script.html"));
ConfigureAsPhishingURL(url);
ASSERT_NO_FATAL_FAILURE(
@@ -653,10 +653,10 @@ IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,
}
// The page-level activation state on the browser-side should not be reset when
-// a same-page navigation starts in the main frame. Vrrify this by dynamically
-// inserting a subframe afterwards, and still expecting activation.
+// a same document navigation starts in the main frame. Verify this by
+// dynamically inserting a subframe afterwards, and still expecting activation.
IN_PROC_BROWSER_TEST_F(SubresourceFilterBrowserTest,
- PageLevelActivationOutlivesSamePageNavigation) {
+ PageLevelActivationOutlivesSameDocumentNavigation) {
GURL url(GetTestUrl(kTestFrameSetPath));
ConfigureAsPhishingURL(url);
ASSERT_NO_FATAL_FAILURE(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698