Image Capture: remove MediaSettingsRange.current

Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values 
still need to be kept around for getMediaTrackSettings(): with 
the |current| member gone, we aneed to dd a new member
|m_settings| to keep them (and it encompasses the previous 
points of interest vector).

LayoutTests updated accordingly.

BUG=700607, 707262
Review-Url: https://codereview.chromium.org/2795923003
Cr-Commit-Position: refs/heads/master@{#461974}
Committed: https://chromium.googlesource.com/chromium/src/+/a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7

[mcasas, 2017-04-04 21:58:37]

Patchset #2 (id:20001) has been deleted

[mcasas, 2017-04-04 21:58:43]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-04-04 22:24:30]

Description was changed from

==========
Image Capture: remove MediaTrackSettings.current

 keep MediaTrackSettings separately


Pulling geolocation and mediacapture-record tests from wpt

BUG=700607, 707262
==========

to

==========
Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values 
still need to be kept around for getMediaTrackSettings(): with 
the |current| member is gone, we add a new member |m_settings|
to keep them (and it swallows the points of interest vector).

LayoutTests updated accordingly.

BUG=700607, 707262
==========

[mcasas, 2017-04-04 22:37:35]

Patchset #1 (id:40001) has been deleted

[mcasas, 2017-04-04 22:38:30]

Description was changed from

==========
Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values 
still need to be kept around for getMediaTrackSettings(): with 
the |current| member is gone, we add a new member |m_settings|
to keep them (and it swallows the points of interest vector).

LayoutTests updated accordingly.

BUG=700607, 707262
==========

to

==========
Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values 
still need to be kept around for getMediaTrackSettings(): with 
the |current| member gone, we aneed to dd a new member
|m_settings| to keep them (and it encompasses the previous 
points of interest vector).

LayoutTests updated accordingly.

BUG=700607, 707262
==========

[mcasas, 2017-04-04 22:38:56]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-04-04 22:38:56]

reillyg@ PTAL

[Reilly Grant (use Gerrit), 2017-04-04 22:46:29]

lgtm with a nit

https://codereview.chromium.org/2795923003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2795923003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:484:
currentPointsOfInterest.push_back(std::move(webPoint));
The Point2D type doesn't have a move constructor so we shouldn't use std::move()
here and make it look like it does.

[mcasas, 2017-04-04 22:52:19]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 22:53:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 22:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:58:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mcasas, 2017-04-04 22:59:47]

https://codereview.chromium.org/2795923003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right):

https://codereview.chromium.org/2795923003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:484:
currentPointsOfInterest.push_back(std::move(webPoint));
On 2017/04/04 22:46:29, Reilly Grant wrote:
> The Point2D type doesn't have a move constructor so we shouldn't use
std::move()
> here and make it look like it does.

Done.

[mcasas, 2017-04-04 23:48:05]

Patchset #3 (id:100001) has been deleted

[mcasas, 2017-04-04 23:48:10]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 23:48:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 01:48:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 01:48:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mcasas, 2017-04-05 01:58:55]

Patchset #3 (id:120001) has been deleted

[mcasas, 2017-04-05 02:02:29]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 02:03:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 03:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 03:38:18]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-04-05 04:02:57]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-04-05 04:02:58]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2795923003/#ps140001
(title: "bugfix: getMediaTrackSettings() should merge dictionaries, not override
the input parameter; Layout…")

[commit-bot: I haz the power, 2017-04-05 04:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 04:08:48]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491364977857080,
"parent_rev": "49e876ae7c44c572607a55bdcc2ef8e992bb3f58", "commit_rev":
"a1052a48bc85cc5d68c0f7dc0782b577e92cc9c7"}

[commit-bot: I haz the power, 2017-04-05 04:09:39]

Description was changed from

==========
Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values 
still need to be kept around for getMediaTrackSettings(): with 
the |current| member gone, we aneed to dd a new member
|m_settings| to keep them (and it encompasses the previous 
points of interest vector).

LayoutTests updated accordingly.

BUG=700607, 707262
==========

to

==========
Image Capture: remove MediaSettingsRange.current

This CL removes MediaSettingsRange.current member, which
was never in the Spec to start with. "Current" feature values 
still need to be kept around for getMediaTrackSettings(): with 
the |current| member gone, we aneed to dd a new member
|m_settings| to keep them (and it encompasses the previous 
points of interest vector).

LayoutTests updated accordingly.

BUG=700607, 707262

Review-Url: https://codereview.chromium.org/2795923003
Cr-Commit-Position: refs/heads/master@{#461974}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1052a48bc85cc5d68c0f7dc0782...
==========

[commit-bot: I haz the power, 2017-04-05 04:09:40]

Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/a1052a48bc85cc5d68c0f7dc0782...