Image Capture: remove MediaSettingsRange.current

third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/imagecapture/ImageCapture.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/fileapi/Blob.h"
 #include "core/frame/ImageBitmap.h"
 #include "modules/EventTargetModules.h"
 #include "modules/imagecapture/MediaSettingsRange.h"
 #include "modules/imagecapture/PhotoCapabilities.h"
 #include "modules/imagecapture/PhotoSettings.h"
 #include "modules/mediastream/MediaStreamTrack.h"
 #include "modules/mediastream/MediaTrackCapabilities.h"
-#include "modules/mediastream/MediaTrackSettings.h"
 #include "platform/WaitableEvent.h"
 #include "platform/mojo/MojoHelper.h"
 #include "public/platform/InterfaceProvider.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebImageCaptureFrameGrabber.h"
 #include "public/platform/WebMediaStreamTrack.h"
 #include "wtf/PtrUtil.h"
 
 namespace blink {
 
@@ skipping 334 matching lines @@
                         convertToBaseCallback(WTF::bind(
                             &ImageCapture::onSetOptions, wrapPersistent(this),
                             wrapPersistent(resolver))));
 }
 
 const MediaTrackConstraintSet& ImageCapture::getMediaTrackConstraints() const {
   return m_currentConstraints;
 }
 
 void ImageCapture::getMediaTrackSettings(MediaTrackSettings& settings) const {
-  if (m_capabilities.hasWhiteBalanceMode())
-    settings.setWhiteBalanceMode(m_capabilities.whiteBalanceMode()[0]);
-  if (m_capabilities.hasExposureMode())
-    settings.setExposureMode(m_capabilities.exposureMode()[0]);
-  if (m_capabilities.hasFocusMode())
-    settings.setFocusMode(m_capabilities.focusMode()[0]);
-
-  if (!m_currentPointsOfInterest.isEmpty())
-    settings.setPointsOfInterest(m_currentPointsOfInterest);
-
-  if (m_capabilities.hasExposureCompensation()) {
-    settings.setExposureCompensation(
-        m_capabilities.exposureCompensation()->current());
-  }
-  if (m_capabilities.hasColorTemperature())
-    settings.setColorTemperature(m_capabilities.colorTemperature()->current());
-  if (m_capabilities.hasIso())
-    settings.setIso(m_capabilities.iso()->current());
-
-  if (m_capabilities.hasBrightness())
-    settings.setBrightness(m_capabilities.brightness()->current());
-  if (m_capabilities.hasContrast())
-    settings.setContrast(m_capabilities.contrast()->current());
-  if (m_capabilities.hasSaturation())
-    settings.setSaturation(m_capabilities.saturation()->current());
-  if (m_capabilities.hasSharpness())
-    settings.setSharpness(m_capabilities.sharpness()->current());
-
-  if (m_capabilities.hasZoom())
-    settings.setZoom(m_capabilities.zoom()->current());
-  if (m_capabilities.hasTorch())
-    settings.setTorch(m_capabilities.torch());
+  settings = m_settings;
 }
 
 ImageCapture::ImageCapture(ExecutionContext* context, MediaStreamTrack* track)
     : ContextLifecycleObserver(context), m_streamTrack(track) {
   DCHECK(m_streamTrack);
   DCHECK(!m_service.is_bound());
 
   Platform::current()->interfaceProvider()->getInterface(
       mojo::MakeRequest(&m_service));
 
@@ skipping 73 matching lines @@
   if (!capabilities.is_null())
     onCapabilitiesUpdateInternal(*capabilities);
 }
 
 void ImageCapture::onCapabilitiesUpdateInternal(
     const media::mojom::blink::PhotoCapabilities& capabilities) {
   // TODO(mcasas): adapt the mojo interface to return a list of supported Modes
   // when moving these out of PhotoCapabilities, https://crbug.com/700607.
   m_capabilities.setWhiteBalanceMode(
       WTF::Vector<WTF::String>({toString(capabilities.white_balance_mode)}));
+  if (m_capabilities.hasWhiteBalanceMode())
+    m_settings.setWhiteBalanceMode(m_capabilities.whiteBalanceMode()[0]);
   m_capabilities.setExposureMode(
       WTF::Vector<WTF::String>({toString(capabilities.exposure_mode)}));
+  if (m_capabilities.hasExposureMode())
+    m_settings.setExposureMode(m_capabilities.exposureMode()[0]);
   m_capabilities.setFocusMode(
       WTF::Vector<WTF::String>({toString(capabilities.focus_mode)}));
+  if (m_capabilities.hasFocusMode())
+    m_settings.setFocusMode(m_capabilities.focusMode()[0]);
 
+  HeapVector<Point2D> currentPointsOfInterest;
   if (!capabilities.points_of_interest.isEmpty()) {
-    m_currentPointsOfInterest.clear();
     for (const auto& point : capabilities.points_of_interest) {
       Point2D webPoint;
       webPoint.setX(point->x);
       webPoint.setY(point->y);
-      m_currentPointsOfInterest.push_back(mojo::Clone(webPoint));
+      currentPointsOfInterest.push_back(std::move(webPoint));

[Reilly Grant (use Gerrit), 2017/04/04 22:46:29]

The Point2D type doesn't have a move constructor so we shouldn't use std::move()
here and make it look like it does.

[mcasas, 2017/04/04 22:59:47]

Done.

     }
   }
+  m_settings.setPointsOfInterest(std::move(currentPointsOfInterest));
 
   // TODO(mcasas): Remove the explicit MediaSettingsRange::create() when
   // mojo::StructTraits supports garbage-collected mappings,
   // https://crbug.com/700180.
   if (capabilities.exposure_compensation->max !=
       capabilities.exposure_compensation->min) {
     m_capabilities.setExposureCompensation(
         MediaSettingsRange::create(*capabilities.exposure_compensation));
+    m_settings.setExposureCompensation(
+        capabilities.exposure_compensation->current);
   }
   if (capabilities.color_temperature->max !=
       capabilities.color_temperature->min) {
     m_capabilities.setColorTemperature(
         MediaSettingsRange::create(*capabilities.color_temperature));
+    m_settings.setColorTemperature(capabilities.color_temperature->current);
   }
-  if (capabilities.iso->max != capabilities.iso->min)
+  if (capabilities.iso->max != capabilities.iso->min) {
     m_capabilities.setIso(MediaSettingsRange::create(*capabilities.iso));
+    m_settings.setIso(capabilities.iso->current);
+  }
 
   if (capabilities.brightness->max != capabilities.brightness->min) {
     m_capabilities.setBrightness(
         MediaSettingsRange::create(*capabilities.brightness));
+    m_settings.setBrightness(capabilities.brightness->current);
   }
   if (capabilities.contrast->max != capabilities.contrast->min) {
     m_capabilities.setContrast(
         MediaSettingsRange::create(*capabilities.contrast));
+    m_settings.setContrast(capabilities.contrast->current);
   }
   if (capabilities.saturation->max != capabilities.saturation->min) {
     m_capabilities.setSaturation(
         MediaSettingsRange::create(*capabilities.saturation));
+    m_settings.setSaturation(capabilities.saturation->current);
   }
   if (capabilities.sharpness->max != capabilities.sharpness->min) {
     m_capabilities.setSharpness(
         MediaSettingsRange::create(*capabilities.sharpness));
+    m_settings.setSharpness(capabilities.sharpness->current);
   }
 
-  if (capabilities.zoom->max != capabilities.zoom->min)
+  if (capabilities.zoom->max != capabilities.zoom->min) {
     m_capabilities.setZoom(MediaSettingsRange::create(*capabilities.zoom));
+    m_settings.setZoom(capabilities.zoom->current);
+  }
 
   m_capabilities.setTorch(capabilities.torch);
 
   // TODO(mcasas): do |torch| when the mojom interface is updated,
   // https://crbug.com/700607.
 }
 
 void ImageCapture::onServiceConnectionError() {
   m_service.reset();
   for (ScriptPromiseResolver* resolver : m_serviceRequests)
     resolver->reject(DOMException::create(NotFoundError, kNoServiceError));
   m_serviceRequests.clear();
 }
 
 DEFINE_TRACE(ImageCapture) {
   visitor->trace(m_streamTrack);
   visitor->trace(m_capabilities);
+  visitor->trace(m_settings);
   visitor->trace(m_currentConstraints);
-  visitor->trace(m_currentPointsOfInterest);
   visitor->trace(m_serviceRequests);
   EventTargetWithInlineData::trace(visitor);
   ContextLifecycleObserver::trace(visitor);
 }
 
 }  // namespace blink