[Merge m58] android: Limit bindToCaller check to webview
There is evidence the BindToCaller check is causing to GPU hangs
although not sure about the exact mechanism. This change guards the
BindToCaller check behind a new setting in ChildProcessCreationParams
and then only enable it in webview.
Note also moved a few lines out of lock protection in
ChildProcessServiceImpl setupConnection.
This is intended to be merged back to m58.
Note this is not a direct cherry-pick of
https://codereview.chromium.org/2796453003 due to conflicts.
BUG=690118R=rsesek@chromium.org
Review-Url: https://codereview.chromium.org/2795913003 .
Cr-Commit-Position: refs/branch-heads/3029@{#608}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/27be1f322e23197fb997aeb218fa7fb7252104dd
ptal This is the same CL on m58. Not a trivial merge since lots of ...
3 years, 8 months ago
(2017-04-04 18:09:32 UTC)
#2
ptal
This is the same CL on m58. Not a trivial merge since lots of things have
changed since m58, so doing a full review here.
Will wait for merge approval and whatnot of course
Robert Sesek
LGTM
3 years, 8 months ago
(2017-04-04 21:41:10 UTC)
#3
LGTM
boliu
Description was changed from ========== [Merge m58] android: Limit bindToCaller check to webview There is ...
3 years, 8 months ago
(2017-04-06 17:14:58 UTC)
#4
Description was changed from
==========
[Merge m58] android: Limit bindToCaller check to webview
There is evidence the BindToCaller check is causing to GPU hangs
although not sure about the exact mechanism. This change guards the
BindToCaller check behind a new setting in ChildProcessCreationParams
and then only enable it in webview.
Note also moved a few lines out of lock protection in
ChildProcessServiceImpl setupConnection.
This is intended to be merged back to m58.
Note this is not a direct cherry-pick of
https://codereview.chromium.org/2796453003 due to conflicts.
BUG=690118
==========
to
==========
[Merge m58] android: Limit bindToCaller check to webview
There is evidence the BindToCaller check is causing to GPU hangs
although not sure about the exact mechanism. This change guards the
BindToCaller check behind a new setting in ChildProcessCreationParams
and then only enable it in webview.
Note also moved a few lines out of lock protection in
ChildProcessServiceImpl setupConnection.
This is intended to be merged back to m58.
Note this is not a direct cherry-pick of
https://codereview.chromium.org/2796453003 due to conflicts.
BUG=690118
R=rsesek@chromium.org
Review-Url: https://codereview.chromium.org/2795913003 .
Cr-Commit-Position: refs/branch-heads/3029@{#608}
Cr-Branched-From:
939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed:
https://chromium.googlesource.com/chromium/src/+/27be1f322e23197fb997aeb218fa...
==========
boliu
Committed patchset #2 (id:20001) manually as 27be1f322e23197fb997aeb218fa7fb7252104dd.
3 years, 8 months ago
(2017-04-06 17:15:00 UTC)
#5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
27be1f322e23197fb997aeb218fa7fb7252104dd.
Issue 2795913003: [Merge m58] android: Limit bindToCaller check to webview
(Closed)
Created 3 years, 8 months ago by boliu
Modified 3 years, 8 months ago
Reviewers: Robert Sesek
Base URL:
Comments: 0