Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2795913003: [Merge m58] android: Limit bindToCaller check to webview (Closed)

Created:
3 years, 8 months ago by boliu
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, dominickn+watch_chromium.org, Peter Beverloo, jam, pkotwicz+watch_chromium.org, agrieve+watch_chromium.org, darin-cc_chromium.org, zpeng+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge m58] android: Limit bindToCaller check to webview There is evidence the BindToCaller check is causing to GPU hangs although not sure about the exact mechanism. This change guards the BindToCaller check behind a new setting in ChildProcessCreationParams and then only enable it in webview. Note also moved a few lines out of lock protection in ChildProcessServiceImpl setupConnection. This is intended to be merged back to m58. Note this is not a direct cherry-pick of https://codereview.chromium.org/2796453003 due to conflicts. BUG=690118 R=rsesek@chromium.org Review-Url: https://codereview.chromium.org/2795913003 . Cr-Commit-Position: refs/branch-heads/3029@{#608} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/27be1f322e23197fb997aeb218fa7fb7252104dd

Patch Set 1 #

Patch Set 2 : remove final from chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -30 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/templates/MonochromeApplication.template View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 5 chunks +11 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 1 chunk +3 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java View 2 chunks +7 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 3 chunks +16 lines, -12 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 2 chunks +6 lines, -4 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
boliu
ptal This is the same CL on m58. Not a trivial merge since lots of ...
3 years, 8 months ago (2017-04-04 18:09:32 UTC) #2
Robert Sesek
LGTM
3 years, 8 months ago (2017-04-04 21:41:10 UTC) #3
boliu
3 years, 8 months ago (2017-04-06 17:15:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
27be1f322e23197fb997aeb218fa7fb7252104dd.

Powered by Google App Engine
This is Rietveld 408576698