Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2795913003: [Merge m58] android: Limit bindToCaller check to webview (Closed)
Patch Set: remove final from chrome Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.webapps; 5 package org.chromium.chrome.browser.webapps;
6 6
7 import android.content.Intent; 7 import android.content.Intent;
8 8
9 import org.chromium.base.ContextUtils; 9 import org.chromium.base.ContextUtils;
10 import org.chromium.base.library_loader.LibraryProcessType; 10 import org.chromium.base.library_loader.LibraryProcessType;
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 * Initializes {@link ChildProcessCreationParams} as a WebAPK's renderer pro cess if 177 * Initializes {@link ChildProcessCreationParams} as a WebAPK's renderer pro cess if
178 * {@link isForWebApk}} is true; as Chrome's child process otherwise. 178 * {@link isForWebApk}} is true; as Chrome's child process otherwise.
179 * @param isForWebApk: Whether the {@link ChildProcessCreationParams} is ini tialized as a 179 * @param isForWebApk: Whether the {@link ChildProcessCreationParams} is ini tialized as a
180 * WebAPK renderer process. 180 * WebAPK renderer process.
181 */ 181 */
182 private void initializeChildProcessCreationParams(boolean isForWebApk) { 182 private void initializeChildProcessCreationParams(boolean isForWebApk) {
183 // TODO(hanxi): crbug.com/664530. WebAPKs shouldn't use a global ChildPr ocessCreationParams. 183 // TODO(hanxi): crbug.com/664530. WebAPKs shouldn't use a global ChildPr ocessCreationParams.
184 ChildProcessCreationParams params = mDefaultParams; 184 ChildProcessCreationParams params = mDefaultParams;
185 if (isForWebApk) { 185 if (isForWebApk) {
186 boolean isExternalService = false; 186 boolean isExternalService = false;
187 boolean bindToCaller = false;
187 params = new ChildProcessCreationParams(getWebappInfo().webApkPackag eName(), 188 params = new ChildProcessCreationParams(getWebappInfo().webApkPackag eName(),
188 isExternalService, LibraryProcessType.PROCESS_CHILD); 189 isExternalService, LibraryProcessType.PROCESS_CHILD, bindToC aller);
189 } 190 }
190 ChildProcessCreationParams.registerDefault(params); 191 ChildProcessCreationParams.registerDefault(params);
191 } 192 }
192 193
193 @Override 194 @Override
194 protected void onDestroyInternal() { 195 protected void onDestroyInternal() {
195 if (mUpdateManager != null) { 196 if (mUpdateManager != null) {
196 mUpdateManager.destroy(); 197 mUpdateManager.destroy();
197 } 198 }
198 super.onDestroyInternal(); 199 super.onDestroyInternal();
199 } 200 }
200 } 201 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698