Chromium Code Reviews

Issue 2795903004: Revert of [heap] Refactor evacuation verifier (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Refactor evacuation verifier (patchset #1 id:1 of https://codereview.chromium.org/2790373002/ ) Reason for revert: Speculative revert. Breaks https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/16112 and seems to lead to flakes. Original issue's description: > [heap] Refactor evacuation verifier > > BUG=chromium:651354 > > Review-Url: https://codereview.chromium.org/2790373002 > Cr-Commit-Position: refs/heads/master@{#44375} > Committed: https://chromium.googlesource.com/v8/v8/+/396f1e242184b936c61dda7a14d1306d43b1863c TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2795903004 Cr-Commit-Position: refs/heads/master@{#44377} Committed: https://chromium.googlesource.com/v8/v8/+/c766727ae69d43db66415a3483acc0e846b444d7

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+64 lines, -80 lines)
M src/heap/mark-compact.cc View 5 chunks +64 lines, -80 lines 0 comments

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [heap] Refactor evacuation verifier
3 years, 8 months ago (2017-04-04 14:05:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795903004/1
3 years, 8 months ago (2017-04-04 14:06:04 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 14:06:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c766727ae69d43db66415a3483acc0e846b...

Powered by Google App Engine