Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2790373002:
[heap] Refactor evacuation verifier (Closed)
|
Created:
3 years, 8 months ago by Michael Lippautz Modified:
3 years, 8 months ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Refactor evacuation verifier
BUG=chromium:651354
Review-Url: https://codereview.chromium.org/2790373002
Cr-Commit-Position: refs/heads/master@{#44375}
Committed: https://chromium.googlesource.com/v8/v8/+/396f1e242184b936c61dda7a14d1306d43b1863c
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (8 generated)
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
ptal https://codereview.chromium.org/2790373002/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/2790373002/diff/1/src/heap/mark-compact.cc#ne... src/heap/mark-compact.cc:257: if (FLAG_use_allocation_folding && (space == heap_->old_space())) { I just copied this part but with the current implementation for allocation folding I see no reason why we would not be able to verify. I will (try) to remove this in a separate CL.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491311038861890, "parent_rev":
"84a4930e47210597d2cad5654fa0fd5012712375", "commit_rev":
"396f1e242184b936c61dda7a14d1306d43b1863c"}
Message was sent while issue was closed.
Description was changed from ========== [heap] Refactor evacuation verifier BUG=chromium:651354 ========== to ========== [heap] Refactor evacuation verifier BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2790373002 Cr-Commit-Position: refs/heads/master@{#44375} Committed: https://chromium.googlesource.com/v8/v8/+/396f1e242184b936c61dda7a14d1306d43b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/396f1e242184b936c61dda7a14d1306d43b...
Message was sent while issue was closed.
Does this possibly origin from this CL? https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2...
Message was sent while issue was closed.
On 2017/04/04 13:41:21, Michael Achenbach wrote: > Does this possibly origin from this CL? > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2... Will check now.
Message was sent while issue was closed.
On 2017/04/04 13:56:16, Michael Lippautz wrote: > On 2017/04/04 13:41:21, Michael Achenbach wrote: > > Does this possibly origin from this CL? > > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2... > > Will check now. I would say that it's not that CL. Looking at the buildbot also suggests a different one.
Message was sent while issue was closed.
On 2017/04/04 13:57:38, Michael Lippautz wrote: > On 2017/04/04 13:56:16, Michael Lippautz wrote: > > On 2017/04/04 13:41:21, Michael Achenbach wrote: > > > Does this possibly origin from this CL? > > > > > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2... > > > > Will check now. > > I would say that it's not that CL. Looking at the buildbot also suggests a > different one. Does it? Got quite flaky with this one. Not a single flake before...
Message was sent while issue was closed.
On 2017/04/04 14:04:01, Michael Achenbach wrote: > On 2017/04/04 13:57:38, Michael Lippautz wrote: > > On 2017/04/04 13:56:16, Michael Lippautz wrote: > > > On 2017/04/04 13:41:21, Michael Achenbach wrote: > > > > Does this possibly origin from this CL? > > > > > > > > > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2... > > > > > > Will check now. > > > > I would say that it's not that CL. Looking at the buildbot also suggests a > > different one. > > Does it? Got quite flaky with this one. Not a single flake before... E.g. https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds... bisect points to this. Output: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds... Will revert for now to get the tree green.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2795903004/ by machenbach@chromium.org. The reason for reverting is: Speculative revert. Breaks https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds... and seems to lead to flakes.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
