[MD settings] hide for-current-incognito checkbox when incognito inactive

[MD settings] hide for-current-incognito checkbox when incognito inactive

This CL changes the checkbox about a content setting exception applying
to the current incognito session. Instead of disabling the checkbox, the
checkbox now becomes hidden.

BUG=704004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795873002
Cr-Commit-Position: refs/heads/master@{#461583}
Committed: https://chromium.googlesource.com/chromium/src/+/40e5b2648dda4c5f2766de6b34070cc54dd7e96d

[dschuyler, 2017-04-03 21:16:44]

Description was changed from

==========
[MD settings] hide for-current-incognito checkbox when incognito inactive

This CL changes the checkbox about a content setting exception applying
to the current incognito session. Instead of disabling the checkbox, the
checkbox now becomes hidden.

BUG=704004
==========

to

==========
[MD settings] hide for-current-incognito checkbox when incognito inactive

This CL changes the checkbox about a content setting exception applying
to the current incognito session. Instead of disabling the checkbox, the
checkbox now becomes hidden.

BUG=704004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-03 21:16:47]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 21:17:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-03 21:17:38]

dschuyler@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-04-03 21:19:33]

lgtm

https://codereview.chromium.org/2795873002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.html
(right):

https://codereview.chromium.org/2795873002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.html:29:
<paper-checkbox id="incognito" hidden$="[[!isIncognitoActive_]]">
nit: id still needed?

[dschuyler, 2017-04-03 21:51:55]

https://codereview.chromium.org/2795873002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/add_site_dialog.html
(right):

https://codereview.chromium.org/2795873002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/add_site_dialog.html:29:
<paper-checkbox id="incognito" hidden$="[[!isIncognitoActive_]]">
On 2017/04/03 21:19:33, stevenjb wrote:
> nit: id still needed?

It's used for some styling (which could be done another way), so yes-ish.

[commit-bot: I haz the power, 2017-04-03 23:43:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 23:43:57]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-04-03 23:47:28]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-04-03 23:48:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 00:04:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491263248295910, "parent_rev":
"3423f23e28e4a31463540df78ed3a49b73c873c6", "commit_rev":
"40e5b2648dda4c5f2766de6b34070cc54dd7e96d"}

[commit-bot: I haz the power, 2017-04-04 00:06:34]

Description was changed from

==========
[MD settings] hide for-current-incognito checkbox when incognito inactive

This CL changes the checkbox about a content setting exception applying
to the current incognito session. Instead of disabling the checkbox, the
checkbox now becomes hidden.

BUG=704004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] hide for-current-incognito checkbox when incognito inactive

This CL changes the checkbox about a content setting exception applying
to the current incognito session. Instead of disabling the checkbox, the
checkbox now becomes hidden.

BUG=704004
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795873002
Cr-Commit-Position: refs/heads/master@{#461583}
Committed:
https://chromium.googlesource.com/chromium/src/+/40e5b2648dda4c5f2766de6b3407...
==========

[commit-bot: I haz the power, 2017-04-04 00:06:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/40e5b2648dda4c5f2766de6b3407...