chrome/browser/resources/settings/site_settings/add_site_dialog.html - Issue 2795873002: [MD settings] hide for-current-incognito checkbox when incognito inactive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/add_site_dialog.html

Issue 2795873002: [MD settings] hide for-current-incognito checkbox when incognito inactive (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/site_settings/add_site_dialog.html

diff --git a/chrome/browser/resources/settings/site_settings/add_site_dialog.html b/chrome/browser/resources/settings/site_settings/add_site_dialog.html

index 6f7fe45d4b6fdff824d1fb3ab62f50f8de9cc8ee..2da3c0bbe04c7831e000d868532a802447fd871b 100644

--- a/chrome/browser/resources/settings/site_settings/add_site_dialog.html

+++ b/chrome/browser/resources/settings/site_settings/add_site_dialog.html

@@ -26,7 +26,7 @@

placeholder="$i18n{addSiteExceptionPlaceholder}"

value="{{site_}}" on-input="validate_"

error-message="$i18n{notValidWebAddress}" autofocus></paper-input>

- <paper-checkbox id="incognito">

+ <paper-checkbox id="incognito" hidden$="[[!isIncognitoActive_]]">

stevenjb 2017/04/03 21:19:33 nit: id still needed?

dschuyler 2017/04/03 21:51:55 It's used for some styling (which could be done an

$i18n{incognitoSiteOnly}

</paper-checkbox>

</div>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/site_settings/add_site_dialog.js » ('j') | no next file with comments »