MD Bookmarks: Handle bookmark creation

MD Bookmarks: Handle bookmark creation

This makes the MD Bookmarks UI update when a bookmark is created from
elsewhere in the browser (eg, from the bookmarks bar). A follow-up CL
will make it possible to create new bookmarks from the MD Bookmarks UI.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795623002
Cr-Commit-Position: refs/heads/master@{#462002}
Committed: https://chromium.googlesource.com/chromium/src/+/b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3

[tsergeant, 2017-04-03 03:26:09]

Description was changed from

==========
MD Bookmarks: Handle bookmark creation

This makes the MD Bookmarks UI update when a bookmark is created from
elsewhere in the browser (eg, from the bookmarks bar). A follow-up CL
will make it possible to create new bookmarks from the MD Bookmarks UI.

BUG=692821
==========

to

==========
MD Bookmarks: Handle bookmark creation

This makes the MD Bookmarks UI update when a bookmark is created from
elsewhere in the browser (eg, from the bookmarks bar). A follow-up CL
will make it possible to create new bookmarks from the MD Bookmarks UI.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-03 03:34:40]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 03:34:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 05:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 05:03:21]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tsergeant, 2017-04-04 01:02:53]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-04-04 01:02:54]

oh, whoops, I was meant to send this to you yesterday.

[calamity, 2017-04-04 08:14:51]

https://codereview.chromium.org/2795623002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/util.js (right):

https://codereview.chromium.org/2795623002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/util.js:33: // The onCreated API listener
returns folders without |children| defined.
K.

https://codereview.chromium.org/2795623002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):

https://codereview.chromium.org/2795623002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/reducers_test.js:229: });
Can we also get a test for a folder creation?

[tsergeant, 2017-04-05 02:45:58]

https://codereview.chromium.org/2795623002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):

https://codereview.chromium.org/2795623002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/reducers_test.js:229: });
On 2017/04/04 08:14:51, calamity wrote:
> Can we also get a test for a folder creation?

That one is a test for folder creation, but I've made it a bit clearer and added
one for creating an item as well.

[tsergeant, 2017-04-05 02:46:03]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 02:46:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 04:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 04:10:41]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-05 07:21:52]

lgtm

[tsergeant, 2017-04-05 07:24:53]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-04-05 07:25:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:31:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491377093587160,
"parent_rev": "559b54453d0d75ba117f938b4eee62184869305d", "commit_rev":
"b23c288a0ff33fafcc8062f48a31bca3bf5fc3b3"}

[commit-bot: I haz the power, 2017-04-05 07:32:50]

Description was changed from

==========
MD Bookmarks: Handle bookmark creation

This makes the MD Bookmarks UI update when a bookmark is created from
elsewhere in the browser (eg, from the bookmarks bar). A follow-up CL
will make it possible to create new bookmarks from the MD Bookmarks UI.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Handle bookmark creation

This makes the MD Bookmarks UI update when a bookmark is created from
elsewhere in the browser (eg, from the bookmarks bar). A follow-up CL
will make it possible to create new bookmarks from the MD Bookmarks UI.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795623002
Cr-Commit-Position: refs/heads/master@{#462002}
Committed:
https://chromium.googlesource.com/chromium/src/+/b23c288a0ff33fafcc8062f48a31...
==========

[commit-bot: I haz the power, 2017-04-05 07:32:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b23c288a0ff33fafcc8062f48a31...