MD Bookmarks: Implement dialog to add new folders/bookmarks

MD Bookmarks: Implement dialog to add new folders/bookmarks

The dialog can be accessed from the menu in the toolbar, and will add
new items to the end of the selected folder.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2780223004
Cr-Commit-Position: refs/heads/master@{#462005}
Committed: https://chromium.googlesource.com/chromium/src/+/85e49faca65081cad27e7c8ed43b02261afcaa96

[tsergeant, 2017-03-30 01:00:40]

Description was changed from

==========
MD Bookmarks: Implement dialog to add new folders/bookmarks

The dialog can be accessed from the menu in the toolbar, and will add
new items to the end of the selected folder.

BUG=692821
==========

to

==========
MD Bookmarks: Implement dialog to add new folders/bookmarks

The dialog can be accessed from the menu in the toolbar, and will add
new items to the end of the selected folder.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-03 04:16:20]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 04:16:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-04-03 04:22:46]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-04-03 04:22:47]

Follow-up to the onCreated CL

[commit-bot: I haz the power, 2017-04-03 05:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 05:19:40]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-03 07:20:48]

lgtm

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/edit_dialog.js (right):

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/edit_dialog.js:97: title = isFolder ?
'addFolderTitle' : 'addBookmarkTitle';
nit: blank line after this.

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.js (right):

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.js:107: isSearchActive_:
function() {
nit: hasSearchTerm_ perhaps? 'Active' search is a bit ambiguous. I thought it
would be calling bookmarks.util.isShowingSearch()

https://codereview.chromium.org/2780223004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/edit_dialog_test.js (right):

https://codereview.chromium.org/2780223004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/edit_dialog_test.js:21: lastUpdate = {};
Reset lastCreation either here or in a teardown.

[tsergeant, 2017-04-04 01:20:02]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 01:20:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-04-04 01:21:07]

tsergeant@chromium.org changed reviewers:
+ dpapad@chromium.org

[tsergeant, 2017-04-04 01:21:08]

+dpapad@ for the little addition to cr-action-menu.

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/edit_dialog.js (right):

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/edit_dialog.js:97: title = isFolder ?
'addFolderTitle' : 'addBookmarkTitle';
On 2017/04/03 07:20:48, calamity wrote:
> nit: blank line after this.

Done.

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/toolbar.js (right):

https://codereview.chromium.org/2780223004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/toolbar.js:107: isSearchActive_:
function() {
On 2017/04/03 07:20:48, calamity wrote:
> nit: hasSearchTerm_ perhaps? 'Active' search is a bit ambiguous. I thought it
> would be calling bookmarks.util.isShowingSearch()

Renamed.

The util function didn't exist when I first wrote this. I think that keeping it
implemented this way makes sense, especially since the polymer update is tied to
searchTerm_, but isShowingSearch() looks at selectedFolder at the moment.

https://codereview.chromium.org/2780223004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/md_bookmarks/edit_dialog_test.js (right):

https://codereview.chromium.org/2780223004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/md_bookmarks/edit_dialog_test.js:21: lastUpdate = {};
On 2017/04/03 07:20:48, calamity wrote:
> Reset lastCreation either here or in a teardown.

Done.

[commit-bot: I haz the power, 2017-04-04 02:35:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 02:35:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dpapad, 2017-04-04 02:50:07]

LGTM for cr_action_menu.html

[tsergeant, 2017-04-05 03:07:59]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 03:08:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 03:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 03:11:20]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2017-04-05 03:11:43]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 03:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 04:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 04:25:21]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-04-05 07:35:49]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-04-05 07:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2780223004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-05 07:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491377749167300,
"parent_rev": "1b260df384fd2c06a4353ca3cd9114cf77a46033", "commit_rev":
"85e49faca65081cad27e7c8ed43b02261afcaa96"}

[commit-bot: I haz the power, 2017-04-05 07:40:58]

Description was changed from

==========
MD Bookmarks: Implement dialog to add new folders/bookmarks

The dialog can be accessed from the menu in the toolbar, and will add
new items to the end of the selected folder.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Implement dialog to add new folders/bookmarks

The dialog can be accessed from the menu in the toolbar, and will add
new items to the end of the selected folder.

BUG=692821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2780223004
Cr-Commit-Position: refs/heads/master@{#462005}
Committed:
https://chromium.googlesource.com/chromium/src/+/85e49faca65081cad27e7c8ed43b...
==========

[commit-bot: I haz the power, 2017-04-05 07:40:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/85e49faca65081cad27e7c8ed43b...