CRD iOS: Adding pin entry view controller.

CRD iOS: Adding pin entry view controller.

This view pops up to allow the user to enter their pin for authenticating
to their crd host session. It will be a modal.

R=lambroslambrou@chromium.org

BUG=652781
Review-Url: https://codereview.chromium.org/2795163003
Cr-Commit-Position: refs/heads/master@{#462117}
Committed: https://chromium.googlesource.com/chromium/src/+/e709b48d0165c2e974d87b0f2268571959470027

[nicholss, 2017-04-04 18:35:28]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 18:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-04-04 18:38:19]

PTAL, thanks!

[commit-bot: I haz the power, 2017-04-04 19:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 19:01:37]

Dry run: This issue passed the CQ dry run.

[Lambros, 2017-04-05 00:17:40]

lgtm

In CL description, s/entry/enter

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
File remoting/client/ios/app/pin_entry_view_controller.h (right):

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.h:12: //
PinEntryViewController is expected to be created, displayed and then
If the user cancels the dialog without entering a PIN, will the callback simply
not be triggered? Does there need to be a Cancelled callback for this case?

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.h:13: // destroyed after the
pin entry is finished; not resued.
s/resued/reused

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
File remoting/client/ios/app/pin_entry_view_controller.mm (right):

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:17: PinEntryModalCallback
_callback;
This callback doesn't seem to be fired anywhere?

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:18: MDCNavigationBar*
_navBar;
Does this need to be a member? It is only used in viewDidLoad.

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:149:
constraintsWithVisualFormat:@"|-[pinEntry]-[pinButton(==70)]-|"
What is ==70 here?

[nicholss, 2017-04-05 16:25:42]

Thanks for the review!

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
File remoting/client/ios/app/pin_entry_view_controller.h (right):

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.h:12: //
PinEntryViewController is expected to be created, displayed and then
On 2017/04/05 00:17:40, Lambros wrote:
> If the user cancels the dialog without entering a PIN, will the callback
simply
> not be triggered? Does there need to be a Cancelled callback for this case?

Hm. I have not implemented the callback reaction yet, this class was just
getting the layout for the pin modal done. I might send in a null host pin as a
cancel. It might have to get reworked as that development gets finished later.

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.h:13: // destroyed after the
pin entry is finished; not resued.
On 2017/04/05 00:17:40, Lambros wrote:
> s/resued/reused

Done.

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
File remoting/client/ios/app/pin_entry_view_controller.mm (right):

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:17: PinEntryModalCallback
_callback;
On 2017/04/05 00:17:40, Lambros wrote:
> This callback doesn't seem to be fired anywhere?

The class is not finished yet, I have not gotten to the point where I have
implemented the pin fetching or callback yet. This is more about layout.

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:18: MDCNavigationBar*
_navBar;
On 2017/04/05 00:17:40, Lambros wrote:
> Does this need to be a member? It is only used in viewDidLoad.

It needs to be held because it is not added to a view, it is just an observer.
It was a choice the MDC folks made... they decorate the standard iOS nav
elements rather than replace.

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:138:
constraintsWithVisualFormat:@"V:|[navBar]-[imageView(="
Stupid auto formatter, this is unreadable. I am moving this constraint to a new
string.

https://codereview.chromium.org/2795163003/diff/1/remoting/client/ios/app/pin...
remoting/client/ios/app/pin_entry_view_controller.mm:149:
constraintsWithVisualFormat:@"|-[pinEntry]-[pinButton(==70)]-|"
On 2017/04/05 00:17:40, Lambros wrote:
> What is ==70 here?

Magic... I will fix.

[nicholss, 2017-04-05 16:26:03]

Description was changed from

==========
CRD iOS: Adding pin entry view controller.

This view pops up to allow the user to entry their pin for authenticating
to their crd host session. It will be a modal.

R=lambroslambrou@chromium.org

BUG=652781
==========

to

==========
CRD iOS: Adding pin entry view controller.

This view pops up to allow the user to enter their pin for authenticating
to their crd host session. It will be a modal.

R=lambroslambrou@chromium.org

BUG=652781
==========

[nicholss, 2017-04-05 16:26:22]

The CQ bit was checked by nicholss@chromium.org

[nicholss, 2017-04-05 16:26:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/2795163003/#ps20001
(title: "Updated based on feedback.")

[commit-bot: I haz the power, 2017-04-05 16:27:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 16:53:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491409582148140,
"parent_rev": "26f8ee4e8a707e4037982a5404b173b751d6e592", "commit_rev":
"e709b48d0165c2e974d87b0f2268571959470027"}

[commit-bot: I haz the power, 2017-04-05 16:54:29]

Description was changed from

==========
CRD iOS: Adding pin entry view controller.

This view pops up to allow the user to enter their pin for authenticating
to their crd host session. It will be a modal.

R=lambroslambrou@chromium.org

BUG=652781
==========

to

==========
CRD iOS: Adding pin entry view controller.

This view pops up to allow the user to enter their pin for authenticating
to their crd host session. It will be a modal.

R=lambroslambrou@chromium.org

BUG=652781

Review-Url: https://codereview.chromium.org/2795163003
Cr-Commit-Position: refs/heads/master@{#462117}
Committed:
https://chromium.googlesource.com/chromium/src/+/e709b48d0165c2e974d87b0f2268...
==========

[commit-bot: I haz the power, 2017-04-05 16:54:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e709b48d0165c2e974d87b0f2268...