remoting/client/ios/app/pin_entry_view_controller.h - Issue 2795163003: CRD iOS: Adding pin entry view controller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/ios/app/pin_entry_view_controller.h

Issue 2795163003: CRD iOS: Adding pin entry view controller. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_CLIENT_IOS_APP_PIN_ENTRY_VIEW_CONTROLLER_H_

	6 #define REMOTING_CLIENT_IOS_APP_PIN_ENTRY_VIEW_CONTROLLER_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 typedef void (^PinEntryModalCallback)(NSString* hostPin, BOOL createPairing);

	11

	12 // PinEntryViewController is expected to be created, displayed and then
	Lambros 2017/04/05 00:17:40 If the user cancels the dialog without entering a If the user cancels the dialog without entering a PIN, will the callback simply not be triggered? Does there need to be a Cancelled callback for this case? nicholss 2017/04/05 16:25:41 Hm. I have not implemented the callback reaction y Show quoted text On 2017/04/05 00:17:40, Lambros wrote: > If the user cancels the dialog without entering a PIN, will the callback simply > not be triggered? Does there need to be a Cancelled callback for this case? Hm. I have not implemented the callback reaction yet, this class was just getting the layout for the pin modal done. I might send in a null host pin as a cancel. It might have to get reworked as that development gets finished later.
	13 // destroyed after the pin entry is finished; not resued.
	Lambros 2017/04/05 00:17:40 s/resued/reused s/resued/reused nicholss 2017/04/05 16:25:41 Done. Show quoted text On 2017/04/05 00:17:40, Lambros wrote: > s/resued/reused Done.
	14 @interface PinEntryViewController : UIViewController

	15

	16 // Callback will be used to return the pin entry result.

	17 - (id)initWithCallback:(PinEntryModalCallback)callback;

	18

	19 @end

	20

	21 #endif // REMOTING_CLIENT_IOS_APP_PIN_ENTRY_VIEW_CONTROLLER_H_

OLD	NEW

« no previous file with comments | « no previous file | remoting/client/ios/app/pin_entry_view_controller.mm » ('j') | remoting/client/ios/app/pin_entry_view_controller.mm » ('J')