Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2795043002: Merge 58: Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder (Closed)

Created:
3 years, 8 months ago by emircan
Modified:
3 years, 8 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge 58: Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2785403002 Cr-Commit-Position: refs/heads/master@{#461058} (cherry picked from commit ce6101035cd668d97f15c3ea4736d75f5c0ce05f) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2795043002 Cr-Commit-Position: refs/branch-heads/3029@{#554} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/20ba2f284b0df94c628a59af2183b08b907f973d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M content/renderer/media_recorder/video_track_recorder.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795043002/1
3 years, 8 months ago (2017-04-03 20:26:55 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 20:32:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20ba2f284b0df94c628a59af2183...

Powered by Google App Engine
This is Rietveld 408576698