Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2785403002:
Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder (Closed)
|
Created:
3 years, 8 months ago by emircan Modified:
3 years, 8 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, emircan+watch+mediarecorder_chromium.org, posciak+watch_chromium.org, jam, darin-cc_chromium.org, mcasas+mediarecorder_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland: Copy based on coded size in VideoTrackRecorder::VEAEncoder
This Cl addresses the below bug making sure that input frame's
coded size is compared to VEA's requested and frame is copied
when necessary.
BUG=705273
TEST=The given bug is fixed and added unittests.
TBR=mcasas@chromium.org
Review-Url: https://codereview.chromium.org/2785403002
Cr-Commit-Position: refs/heads/master@{#461058}
Committed: https://chromium.googlesource.com/chromium/src/+/ce6101035cd668d97f15c3ea4736d75f5c0ce05f
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 24 (21 generated)
Description was changed from ========== Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. Review-Url: https://codereview.chromium.org/2790443004 Cr-Commit-Position: refs/heads/master@{#460897} Committed: https://chromium.googlesource.com/chromium/src/+/68c20537e9ecd5715ffe280091c3... patch from issue 2790443004 at patchset 40001 (http://crrev.com/2790443004#ps40001) ========== to ========== Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. Review-Url: https://codereview.chromium.org/2790443004 Cr-Commit-Position: refs/heads/master@{#460897} Committed: https://chromium.googlesource.com/chromium/src/+/68c20537e9ecd5715ffe280091c3... patch from issue 2790443004 at patchset 40001 (http://crrev.com/2790443004#ps40001) ==========
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
The CQ bit was unchecked by emircan@chromium.org
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
The CQ bit was unchecked by emircan@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by emircan@chromium.org
Description was changed from ========== Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. Review-Url: https://codereview.chromium.org/2790443004 Cr-Commit-Position: refs/heads/master@{#460897} Committed: https://chromium.googlesource.com/chromium/src/+/68c20537e9ecd5715ffe280091c3... patch from issue 2790443004 at patchset 40001 (http://crrev.com/2790443004#ps40001) ========== to ========== Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. TBR=mcasas@chromium.org ==========
emircan@chromium.org changed reviewers: + mcasas@chromium.org
One line change to pass the failing bot in PS#2.
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490941812984340,
"parent_rev": "8493df9b1ea5104fc6e2278b6dbe2ba4d5e19520", "commit_rev":
"ce6101035cd668d97f15c3ea4736d75f5c0ce05f"}
Message was sent while issue was closed.
Description was changed from ========== Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. TBR=mcasas@chromium.org ========== to ========== Reland: Copy based on coded size in VideoTrackRecorder::VEAEncoder This Cl addresses the below bug making sure that input frame's coded size is compared to VEA's requested and frame is copied when necessary. BUG=705273 TEST=The given bug is fixed and added unittests. TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2785403002 Cr-Commit-Position: refs/heads/master@{#461058} Committed: https://chromium.googlesource.com/chromium/src/+/ce6101035cd668d97f15c3ea4736... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ce6101035cd668d97f15c3ea4736... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
