Issue 2794853003: Delete duplicate win32 xmlversion.h header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2794853003: Delete duplicate win32 xmlversion.h header file. (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Delete duplicate win32 xmlversion.h header file. It's unclear which configuration of libxml2 we're using on Windows. BUG=692731, 604167 Review-Url: https://codereview.chromium.org/2792903002 Cr-Commit-Position: refs/heads/master@{#461377} (cherry picked from commit f1f078d5f56503e5cf8b5490875e1e1ec9c252ba) Review-Url: https://codereview.chromium.org/2794853003 . Cr-Commit-Position: refs/branch-heads/3029@{#539} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c3c1eab11e66eb19a716c1b0bc1f3a3a784d9740

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -497 lines)			Patch
M	third_party/libxml/README.chromium	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libxml/win32/include/libxml/xmlversion.h	View	5 chunks	+7 lines, -7 lines	0 comments	Download
D	third_party/libxml/win32/xmlversion.h	View	1 chunk	+0 lines, -489 lines	0 comments	Download

Total messages: 2 (1 generated)

dominicc (has gone to gerrit)

3 years, 8 months ago (2017-04-03 07:47:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c3c1eab11e66eb19a716c1b0bc1f3a3a784d9740.