Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2792903002: Delete duplicate win32 xmlversion.h header file. (Closed)

Created:
3 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
ail_google.com, chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete duplicate win32 xmlversion.h header file. It's unclear which configuration of libxml2 we're using on Windows. BUG=692731, 604167 Review-Url: https://codereview.chromium.org/2792903002 Cr-Commit-Position: refs/heads/master@{#461377} Committed: https://chromium.googlesource.com/chromium/src/+/f1f078d5f56503e5cf8b5490875e1e1ec9c252ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -497 lines) Patch
M third_party/libxml/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/win32/include/libxml/xmlversion.h View 5 chunks +7 lines, -7 lines 0 comments Download
D third_party/libxml/win32/xmlversion.h View 1 chunk +0 lines, -489 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dominicc (has gone to gerrit)
PTAL
3 years, 8 months ago (2017-04-03 05:48:39 UTC) #4
yosin_UTC9
lgtm Thanks for clean up!
3 years, 8 months ago (2017-04-03 06:02:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792903002/1
3 years, 8 months ago (2017-04-03 06:48:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 06:54:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1f078d5f56503e5cf8b5490875e...

Powered by Google App Engine
This is Rietveld 408576698