Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2794613002: Remove FullCardRequest's dependency on AutofillClient. (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
Reviewers:
Mathieu
CC:
browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, mathp+autofillwatch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FullCardRequest's dependency on AutofillClient. BUG=706511 Review-Url: https://codereview.chromium.org/2794613002 Cr-Commit-Position: refs/heads/master@{#461209} Committed: https://chromium.googlesource.com/chromium/src/+/ddc6c499fc6f05937be269de5c0daf54b0d298fb

Patch Set 1 #

Patch Set 2 : Add risk_data_loader.h to BUILD. #

Total comments: 3

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M components/autofill/core/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_client.h View 4 chunks +3 lines, -6 lines 0 comments Download
M components/autofill/core/browser/payments/full_card_request.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M components/autofill/core/browser/payments/full_card_request.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A components/autofill/core/browser/risk_data_loader.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
anthonyvd
Hi Math, can you PTAL? Thanks!
3 years, 8 months ago (2017-03-31 19:00:19 UTC) #4
Mathieu
Thanks for doing this! lgtm https://codereview.chromium.org/2794613002/diff/20001/components/autofill/core/browser/payments/full_card_request.h File components/autofill/core/browser/payments/full_card_request.h (right): https://codereview.chromium.org/2794613002/diff/20001/components/autofill/core/browser/payments/full_card_request.h#newcode86 components/autofill/core/browser/payments/full_card_request.h:86: // Responsible for showing ...
3 years, 8 months ago (2017-03-31 19:04:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794613002/40001
3 years, 8 months ago (2017-03-31 19:15:42 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ddc6c499fc6f05937be269de5c0daf54b0d298fb
3 years, 8 months ago (2017-03-31 20:27:25 UTC) #11
anthonyvd
3 years, 8 months ago (2017-04-03 15:01:20 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2794613002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/risk_data_loader.h (right):

https://codereview.chromium.org/2794613002/diff/20001/components/autofill/cor...
components/autofill/core/browser/risk_data_loader.h:16: virtual
~RiskDataLoader() {}
On 2017/03/31 at 19:04:03, Mathieu wrote:
> I think this can be protected?

Done.

Powered by Google App Engine
This is Rietveld 408576698