Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: components/autofill/core/browser/autofill_client.h

Issue 2794613002: Remove FullCardRequest's dependency on AutofillClient. (Closed)
Patch Set: Address comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_client.h
diff --git a/components/autofill/core/browser/autofill_client.h b/components/autofill/core/browser/autofill_client.h
index d36f0026ffca6da8b3f830375f1be2af3514a457..a10c3b302684c78690546db6f8b465235c3e553b 100644
--- a/components/autofill/core/browser/autofill_client.h
+++ b/components/autofill/core/browser/autofill_client.h
@@ -14,6 +14,7 @@
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "base/values.h"
+#include "components/autofill/core/browser/risk_data_loader.h"
#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
@@ -57,7 +58,7 @@ struct Suggestion;
// AutofillManager is used (e.g. a single tab), so when we say "for the client"
// below, we mean "in the execution context the client is associated with" (e.g.
// for the tab the AutofillManager is attached to).
-class AutofillClient {
+class AutofillClient : public RiskDataLoader {
public:
enum PaymentsRpcResult {
// Empty result. Used for initializing variables and should generally
@@ -89,7 +90,7 @@ class AutofillClient {
typedef base::Callback<void(const CreditCard&)> CreditCardScanCallback;
- virtual ~AutofillClient() {}
+ ~AutofillClient() override {}
// Gets the PersonalDataManager instance associated with the client.
virtual PersonalDataManager* GetPersonalDataManager() = 0;
@@ -139,10 +140,6 @@ class AutofillClient {
virtual void ConfirmCreditCardFillAssist(const CreditCard& card,
const base::Closure& callback) = 0;
- // Gathers risk data and provides it to |callback|.
- virtual void LoadRiskData(
- const base::Callback<void(const std::string&)>& callback) = 0;
-
// Returns true if both the platform and the device support scanning credit
// cards. Should be called before ScanCreditCard().
virtual bool HasCreditCardScanFeature() = 0;
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/autofill/core/browser/payments/full_card_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698