Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2794543002: Enable -Wdeprecated-register in CrOS builds. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, satorux1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable -Wdeprecated-register in CrOS builds. This was blocked on the CrOS build not using the jessie sysroot, but now it does. BUG=705812 Review-Url: https://codereview.chromium.org/2794543002 Cr-Commit-Position: refs/heads/master@{#461153} Committed: https://chromium.googlesource.com/chromium/src/+/e2aa9636a2086da87bba7d5ebca09fd831504d4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Nico
3 years, 8 months ago (2017-03-31 15:24:02 UTC) #4
dcheng
lgtm
3 years, 8 months ago (2017-03-31 16:28:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794543002/1
3 years, 8 months ago (2017-03-31 16:35:31 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 17:05:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2aa9636a2086da87bba7d5ebca0...

Powered by Google App Engine
This is Rietveld 408576698