Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2794543002: Enable -Wdeprecated-register in CrOS builds. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/compiler/compiler.gni") 8 import("//build/config/compiler/compiler.gni")
9 import("//build/config/nacl/config.gni") 9 import("//build/config/nacl/config.gni")
10 import("//build/toolchain/cc_wrapper.gni") 10 import("//build/toolchain/cc_wrapper.gni")
(...skipping 1055 matching lines...) Expand 10 before | Expand all | Expand 10 after
1066 1066
1067 # TODO(thakis): This used to be implied by -Wno-unused-function, 1067 # TODO(thakis): This used to be implied by -Wno-unused-function,
1068 # which we no longer use. Check if it makes sense to remove 1068 # which we no longer use. Check if it makes sense to remove
1069 # this as well. http://crbug.com/316352 1069 # this as well. http://crbug.com/316352
1070 "-Wno-unneeded-internal-declaration", 1070 "-Wno-unneeded-internal-declaration",
1071 1071
1072 # TODO(hans): Get this cleaned up, http://crbug.com/428099 1072 # TODO(hans): Get this cleaned up, http://crbug.com/428099
1073 "-Wno-inconsistent-missing-override", 1073 "-Wno-inconsistent-missing-override",
1074 ] 1074 ]
1075 1075
1076 if (is_chromeos || (is_linux && target_cpu == "x86")) { 1076 if (is_linux && target_cpu == "x86") {
1077 cflags += [ 1077 cflags += [
1078 # TODO(thakis): Figure out why CrOS needs this, fix, remove.
1079 # https://crbug.com/806812
1080 # TODO(thakis): Remove from 32-bit Linux eventually, https://707084 1078 # TODO(thakis): Remove from 32-bit Linux eventually, https://707084
1081 "-Wno-deprecated-register", 1079 "-Wno-deprecated-register",
1082 ] 1080 ]
1083 } 1081 }
1084 1082
1085 # use_xcode_clang only refers to the iOS toolchain, host binaries use 1083 # use_xcode_clang only refers to the iOS toolchain, host binaries use
1086 # chromium's clang always. 1084 # chromium's clang always.
1087 if (!is_nacl && (!use_xcode_clang || current_toolchain == host_toolchain)) { 1085 if (!is_nacl && (!use_xcode_clang || current_toolchain == host_toolchain)) {
1088 # Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not 1086 # Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not
1089 # recognize. 1087 # recognize.
(...skipping 623 matching lines...) Expand 10 before | Expand all | Expand 10 after
1713 1711
1714 if (is_ios || is_mac) { 1712 if (is_ios || is_mac) {
1715 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1713 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1716 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1714 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1717 config("enable_arc") { 1715 config("enable_arc") {
1718 common_flags = [ "-fobjc-arc" ] 1716 common_flags = [ "-fobjc-arc" ]
1719 cflags_objc = common_flags 1717 cflags_objc = common_flags
1720 cflags_objcc = common_flags 1718 cflags_objcc = common_flags
1721 } 1719 }
1722 } 1720 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698