Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2794423002: Initialize TaskScheduler with InitParams in service_process.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize TaskScheduler with InitParams in service_process.cc. Initialization with a vector of SchedulerWorkerPoolParams is deprecated. BUG=690706 Review-Url: https://codereview.chromium.org/2794423002 Cr-Commit-Position: refs/heads/master@{#463336} Committed: https://chromium.googlesource.com/chromium/src/+/5f60fb4d0d4527442621b0626edac9ca97a27fa2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M chrome/service/service_process.cc View 1 chunk +24 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-04 19:01:33 UTC) #2
fdoray
ping + adding additional reviews in case Scott Byer is not available.
3 years, 8 months ago (2017-04-10 13:53:31 UTC) #4
fdoray
ping + adding additional reviewers in case Scott Byer is not available.
3 years, 8 months ago (2017-04-10 13:53:48 UTC) #5
Scott Byer
lgtm
3 years, 8 months ago (2017-04-10 17:41:03 UTC) #6
Vitaly Buka (NO REVIEWS)
3 years, 8 months ago (2017-04-10 17:43:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794423002/1
3 years, 8 months ago (2017-04-10 17:43:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:30:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f60fb4d0d4527442621b0626eda...

Powered by Google App Engine
This is Rietveld 408576698