Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2795693006: Initialize TaskScheduler with InitParams in ScopedAsyncTaskScheduler. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize TaskScheduler with InitParams in ScopedAsyncTaskScheduler. Initialization with a vector of SchedulerWorkerPoolParams is deprecated. BUG=690706 Review-Url: https://codereview.chromium.org/2795693006 Cr-Commit-Position: refs/heads/master@{#462057} Committed: https://chromium.googlesource.com/chromium/src/+/fb0d1678d04256ad6e41aaa88a7edd83ca8ca030

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR-robliao-4-reword-comment #

Patch Set 3 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M base/test/scoped_async_task_scheduler.cc View 1 2 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-04 17:37:22 UTC) #2
gab
lgtm
3 years, 8 months ago (2017-04-04 20:45:47 UTC) #3
robliao
lgtm + comment https://codereview.chromium.org/2795693006/diff/1/base/test/scoped_async_task_scheduler.cc File base/test/scoped_async_task_scheduler.cc (right): https://codereview.chromium.org/2795693006/diff/1/base/test/scoped_async_task_scheduler.cc#newcode17 base/test/scoped_async_task_scheduler.cc:17: // Instantiate a TaskScheduler with 1 ...
3 years, 8 months ago (2017-04-04 20:47:31 UTC) #4
fdoray
https://codereview.chromium.org/2795693006/diff/1/base/test/scoped_async_task_scheduler.cc File base/test/scoped_async_task_scheduler.cc (right): https://codereview.chromium.org/2795693006/diff/1/base/test/scoped_async_task_scheduler.cc#newcode17 base/test/scoped_async_task_scheduler.cc:17: // Instantiate a TaskScheduler with 1 thread that is ...
3 years, 8 months ago (2017-04-05 12:51:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795693006/40001
3 years, 8 months ago (2017-04-05 12:51:24 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 13:56:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fb0d1678d04256ad6e41aaa88a7e...

Powered by Google App Engine
This is Rietveld 408576698