Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2794353003: Hide the download summary on file open (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Hide the download summary on file open Notifications can be dismissed with a DownloadManager.ACTION_NOTIFICATION_CLICKED intent, which bypasses the DownloadNotificationService so we don't get a chance to hide the summary. This adds a check to the DownloadBroadcastReceiver#openDownload() path that allows us to hide any dangling summary notifications that shouldn't be visible. This also lets us catch any clicks on the summary which gives us a chance to close them out as well. BUG=699323 Review-Url: https://codereview.chromium.org/2796573002 Cr-Commit-Position: refs/heads/master@{#461744} (cherry picked from commit 803fdf80f842803c7c91dca2a87419afe1b3d60c) Review-Url: https://codereview.chromium.org/2794353003 . Cr-Commit-Position: refs/branch-heads/3029@{#578} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/f1549937850de9b1959a59b6f0e84a33c5319faf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 6 chunks +42 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
David Trainor- moved to gerrit
3 years, 8 months ago (2017-04-04 20:16:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1549937850de9b1959a59b6f0e84a33c5319faf.

Powered by Google App Engine
This is Rietveld 408576698