Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2794343003: cc: Allow overlay candidates with transforms. (Closed)

Created:
3 years, 8 months ago by Daniele Castagna
Modified:
3 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Allow overlay candidates with transforms. After https://codereview.chromium.org/2789363004 landed, Ozone Drm supports the KMS "rotation" property that can be used to set a transform to HW overlays. This CL relaxes the transform restrictions of the fullscreen and single on top overlay strategies. Additionally, it makes sure that any configuration containing a transform will be reject if the legacy page flip is being used. After this CL WebGL and Pepper content can be promoted to HW overlay when backed by a Gpu Memory Buffer. BUG=b/36752417 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2794343003 Cr-Commit-Position: refs/heads/master@{#467697} Committed: https://chromium.googlesource.com/chromium/src/+/923beb5a83a9ccc76ac0b14e9dbeace2983ec8b5

Patch Set 1 #

Patch Set 2 : Rebase on master. #

Patch Set 3 : Initialize plane transform to none. #

Patch Set 4 : OverlayCheck_PArams default transform to none. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M cc/output/overlay_strategy_fullscreen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/output/overlay_strategy_single_on_top.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_message_params.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/overlay_plane.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 33 (25 generated)
Daniele Castagna
3 years, 8 months ago (2017-04-26 23:57:42 UTC) #19
dnicoara
lgtm
3 years, 7 months ago (2017-04-27 14:04:16 UTC) #22
Daniele Castagna
+ccameron for ownership of cc/* and ui/* +rsesek for ownership of ui/ozone/common/gpu/ozone_gpu_message_params.h
3 years, 7 months ago (2017-04-27 14:15:24 UTC) #24
Robert Sesek
ozone_gpu_message_params.h LGTM
3 years, 7 months ago (2017-04-27 14:44:07 UTC) #25
Daniele Castagna
+reveman for cc/output/* ownership since ccameron is OOO.
3 years, 7 months ago (2017-04-27 15:54:52 UTC) #27
reveman
lgtm
3 years, 7 months ago (2017-04-27 15:57:04 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794343003/60001
3 years, 7 months ago (2017-04-27 15:57:45 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 16:05:55 UTC) #33
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/923beb5a83a9ccc76ac0b14e9dbe...

Powered by Google App Engine
This is Rietveld 408576698