ozone: Add KMS "rotation" property support.

ozone: Add KMS "rotation" property support.

Once https://chromium-review.googlesource.com/c/468191/ lands
in the kernel we should be able to use rotation KMS property.

While this CL adds support for all the values of the property "rotation",
initially the only supported value on rockchip will be "reflect-y", this
will allow Chrome to promote WebGL and Pepper content to HW overlay.


BUG=b/36752417

Review-Url: https://codereview.chromium.org/2789363004
Cr-Commit-Position: refs/heads/master@{#463777}
Committed: https://chromium.googlesource.com/chromium/src/+/0877ce62e907e9a76083121c29ce4c7d31f2949f

[Daniele Castagna, 2017-04-05 01:23:19]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 01:24:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2017-04-05 02:10:52]

Description was changed from

==========
ozone: Add KMS rotation property support.

BUG=
==========

to

==========
ozone: Add KMS "rotation" property support.

Once https://chromium-review.googlesource.com/c/468191/ lands
in the kernel we should be able to use rotation KMS property.

While this CL adds support for all the values of the property "rotation",
initially the only supported value on rockchio will be "reflect-y", this
will allow Chrome to promote WebGL and Pepper content to HW overlay.


BUG=b/36752417
==========

[Daniele Castagna, 2017-04-05 02:16:27]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org, hoegsberg@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:22:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 02:22:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2017-04-11 00:01:06]

Description was changed from

==========
ozone: Add KMS "rotation" property support.

Once https://chromium-review.googlesource.com/c/468191/ lands
in the kernel we should be able to use rotation KMS property.

While this CL adds support for all the values of the property "rotation",
initially the only supported value on rockchio will be "reflect-y", this
will allow Chrome to promote WebGL and Pepper content to HW overlay.


BUG=b/36752417
==========

to

==========
ozone: Add KMS "rotation" property support.

Once https://chromium-review.googlesource.com/c/468191/ lands
in the kernel we should be able to use rotation KMS property.

While this CL adds support for all the values of the property "rotation",
initially the only supported value on rockchip will be "reflect-y", this
will allow Chrome to promote WebGL and Pepper content to HW overlay.


BUG=b/36752417
==========

[Daniele Castagna, 2017-04-11 00:01:15]

https://chromium-review.googlesource.com/c/470606/ has just landed.
dnicoara@: Do you have time to take a look at this CL?

[spang, 2017-04-11 00:07:44]

spang@chromium.org changed reviewers:
+ spang@chromium.org

[spang, 2017-04-11 00:07:44]

https://codereview.chromium.org/2789363004/diff/1/ui/ozone/platform/drm/gpu/h...
File ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc (right):

https://codereview.chromium.org/2789363004/diff/1/ui/ozone/platform/drm/gpu/h...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:111:
drmModeAtomicAddProperty(
This one doesn't need to be checked?

[Daniele Castagna, 2017-04-11 00:25:45]

https://codereview.chromium.org/2789363004/diff/1/ui/ozone/platform/drm/gpu/h...
File ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc (right):

https://codereview.chromium.org/2789363004/diff/1/ui/ozone/platform/drm/gpu/h...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:111:
drmModeAtomicAddProperty(
On 2017/04/11 at 00:07:44, spang wrote:
> This one doesn't need to be checked?

I initially thought this would do a syscall and check if the property was
attached to drm object, but it seems like this call is just adding the property
to the set in user space.
It basically can fail only on OOM.

Moved into the check with the other addproperties.

[Daniele Castagna, 2017-04-11 00:25:50]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 00:26:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2017-04-11 00:32:39]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 00:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 01:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:07:36]

Dry run: This issue passed the CQ dry run.

[dnicoara, 2017-04-11 13:51:06]

lgtm

https://codereview.chromium.org/2789363004/diff/40001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc (right):

https://codereview.chromium.org/2789363004/diff/40001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:24: const int
kDrmRotate0 = 0;
Do you know if there's plans to have these in libdrm headers?

https://codereview.chromium.org/2789363004/diff/40001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:29: const int
kDrmReflectY = 32;
nit: Could these be in hex or as bit shifts?

[Daniele Castagna, 2017-04-11 20:21:05]

https://codereview.chromium.org/2789363004/diff/40001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc (right):

https://codereview.chromium.org/2789363004/diff/40001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:24: const int
kDrmRotate0 = 0;
On 2017/04/11 at 13:51:06, dnicoara wrote:
> Do you know if there's plans to have these in libdrm headers?

I just asked Kristian and he agreed it should probably be there already.
Currently DRM_ROTATE_0/90 and co. are defined only in drm_crtc.h

For now, I copied those defines here and put them in an #if
!defined(DRM_ROTATE_0), so that once we moved them in libdrm we can get rid of
this copy.

https://codereview.chromium.org/2789363004/diff/40001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:29: const int
kDrmReflectY = 32;
On 2017/04/11 at 13:51:06, dnicoara wrote:
> nit: Could these be in hex or as bit shifts?

Re-used the drm_crtc defines. The bit shifts is now in the switch case in
OverlayTransformToDrmRotationPropertyValue.

[Daniele Castagna, 2017-04-11 20:31:10]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2017-04-11 20:31:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dnicoara@chromium.org
Link to the patchset: https://codereview.chromium.org/2789363004/#ps60001
(title: "Use drm_crtc.h defines.")

[commit-bot: I haz the power, 2017-04-11 20:32:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hoegsberg1, 2017-04-11 21:24:31]

hoegsberg@google.com changed reviewers:
+ hoegsberg@google.com

[hoegsberg1, 2017-04-11 21:24:31]

https://codereview.chromium.org/2789363004/diff/60001/ui/ozone/platform/drm/g...
File ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc (right):

https://codereview.chromium.org/2789363004/diff/60001/ui/ozone/platform/drm/g...
ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc:24: //
TODO(dcastagna): Remove the following defines once they're in libdrm headers.
I think the "ABI" is the property strings, not these defines. You are supposed
to look for the property names first and discover the integer value from that.
Ideally up front, but could also be on demand like here:

https://cgit.freedesktop.org/mesa/kmscube/tree/drm-atomic.c

[commit-bot: I haz the power, 2017-04-11 21:30:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491942670978130,
"parent_rev": "136d94d61e825232fccd78145cd94f86f5c20aae", "commit_rev":
"0877ce62e907e9a76083121c29ce4c7d31f2949f"}

[Daniele Castagna, 2017-04-11 21:31:30]

The CQ bit was unchecked by dcastagna@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:31:33]

Description was changed from

==========
ozone: Add KMS "rotation" property support.

Once https://chromium-review.googlesource.com/c/468191/ lands
in the kernel we should be able to use rotation KMS property.

While this CL adds support for all the values of the property "rotation",
initially the only supported value on rockchip will be "reflect-y", this
will allow Chrome to promote WebGL and Pepper content to HW overlay.


BUG=b/36752417
==========

to

==========
ozone: Add KMS "rotation" property support.

Once https://chromium-review.googlesource.com/c/468191/ lands
in the kernel we should be able to use rotation KMS property.

While this CL adds support for all the values of the property "rotation",
initially the only supported value on rockchip will be "reflect-y", this
will allow Chrome to promote WebGL and Pepper content to HW overlay.


BUG=b/36752417

Review-Url: https://codereview.chromium.org/2789363004
Cr-Commit-Position: refs/heads/master@{#463777}
Committed:
https://chromium.googlesource.com/chromium/src/+/0877ce62e907e9a76083121c29ce...
==========

[commit-bot: I haz the power, 2017-04-11 21:31:34]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0877ce62e907e9a76083121c29ce...