Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2794233002: Revert of Convert colorSettins attribute in ImageData.idl to a getter method (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, blink-reviews-html_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, dglazkov+blink, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert colorSettins attribute in ImageData.idl to a getter method (patchset #2 id:20001 of https://codereview.chromium.org/2788373003/ ) Reason for revert: Trying to land a revert of https://codereview.chromium.org/2771813003/ which added flaky crashing tests, but this conflicts with it. Original issue's description: > Convert colorSettins attribute in ImageData.idl to a getter method > > ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method. > > BUG=702578 > > Review-Url: https://codereview.chromium.org/2788373003 > Cr-Commit-Position: refs/heads/master@{#461567} > Committed: https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5e15ba303dc01 TBR=junov@chromium.org,zakerinasab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702578 Review-Url: https://codereview.chromium.org/2794233002 Cr-Commit-Position: refs/heads/master@{#461634} Committed: https://chromium.googlesource.com/chromium/src/+/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Timothy Loh
Created Revert of Convert colorSettins attribute in ImageData.idl to a getter method
3 years, 8 months ago (2017-04-04 05:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794233002/1
3 years, 8 months ago (2017-04-04 05:16:41 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 05:18:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a08d8f3b27df0ff438dc9bf7b90...

Powered by Google App Engine
This is Rietveld 408576698