The CQ bit was checked by timloh@chromium.org
Created Revert of Convert colorSettins attribute in ImageData.idl to a getter method
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1491282984984300, "parent_rev": "ebc9c38753d2c3736fa96018bea462c64d1e6602", "commit_rev": "1a08d8f3b27df0ff438dc9bf7b903bc1893636bb"}
Description was changed from ========== Revert of Convert colorSettins attribute in ImageData.idl to a getter method (patchset #2 id:20001 of https://codereview.chromium.org/2788373003/ ) Reason for revert: Trying to land a revert of https://codereview.chromium.org/2771813003/ which added flaky crashing tests, but this conflicts with it. Original issue's description: > Convert colorSettins attribute in ImageData.idl to a getter method > > ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method. > > BUG=702578 > > Review-Url: https://codereview.chromium.org/2788373003 > Cr-Commit-Position: refs/heads/master@{#461567} > Committed: https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5... TBR=junov@chromium.org,zakerinasab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702578 ========== to ========== Revert of Convert colorSettins attribute in ImageData.idl to a getter method (patchset #2 id:20001 of https://codereview.chromium.org/2788373003/ ) Reason for revert: Trying to land a revert of https://codereview.chromium.org/2771813003/ which added flaky crashing tests, but this conflicts with it. Original issue's description: > Convert colorSettins attribute in ImageData.idl to a getter method > > ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method. > > BUG=702578 > > Review-Url: https://codereview.chromium.org/2788373003 > Cr-Commit-Position: refs/heads/master@{#461567} > Committed: https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5... TBR=junov@chromium.org,zakerinasab@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=702578 Review-Url: https://codereview.chromium.org/2794233002 Cr-Commit-Position: refs/heads/master@{#461634} Committed: https://chromium.googlesource.com/chromium/src/+/1a08d8f3b27df0ff438dc9bf7b90... ==========
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1a08d8f3b27df0ff438dc9bf7b90...