Convert colorSettings attribute in ImageData.idl to a getter method

Convert colorSettings attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method.

BUG=702578
Review-Url: https://codereview.chromium.org/2788373003
Cr-Original-Commit-Position: refs/heads/master@{#461567}
Committed: https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5e15ba303dc01
Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461803}
Committed: https://chromium.googlesource.com/chromium/src/+/dfdfa5a0d0415d80b0f284e14e90638c4b54b025

[zakerinasab, 2017-04-03 15:43:19]

Description was changed from

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578
==========

to

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578
==========

[zakerinasab, 2017-04-03 15:43:19]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-04-03 15:43:45]

CL uploaded. PTAL. I'll prepare a pull request for the proposal.

[Justin Novosad, 2017-04-03 18:51:07]

lgtm with nit

https://codereview.chromium.org/2788373003/diff/1/third_party/WebKit/Performa...
File third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html
(left):

https://codereview.chromium.org/2788373003/diff/1/third_party/WebKit/Performa...
third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html:34: 
Don't commit whitespace changes please (adds noise to file history).

[zakerinasab, 2017-04-03 20:09:31]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-04-03 20:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2788373003/#ps20001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-04-03 20:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 22:50:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491250171031720,
"parent_rev": "ab0e2203cdb233620ef341cc297fc3d87ca0ddc5", "commit_rev":
"e38d3b532968ecfd27886ba3e08de5e1858fa9aa"}

[commit-bot: I haz the power, 2017-04-03 22:55:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491250171031720,
"parent_rev": "ce897e8ed500323ddc5544a945287b9dae98831b", "commit_rev":
"c15a4e2b594e61442419a6fec5c5e15ba303dc01"}

[commit-bot: I haz the power, 2017-04-03 22:56:07]

Description was changed from

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578
==========

to

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
==========

[commit-bot: I haz the power, 2017-04-03 22:56:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...

[Timothy Loh, 2017-04-04 05:16:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2794233002/ by timloh@chromium.org.

The reason for reverting is: Trying to land a revert of
https://codereview.chromium.org/2771813003/ which added flaky crashing tests,
but this conflicts with it..

[zakerinasab, 2017-04-04 17:42:57]

Description was changed from

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
==========

to

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
==========

[zakerinasab, 2017-04-04 17:43:02]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-04-04 17:43:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 19:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491327782440220,
"parent_rev": "0a0f508c228156c161f59858e65c6ee06c14d650", "commit_rev":
"dfdfa5a0d0415d80b0f284e14e90638c4b54b025"}

[commit-bot: I haz the power, 2017-04-04 19:43:00]

Description was changed from

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
==========

to

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Original-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461803}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfdfa5a0d0415d80b0f284e14e90...
==========

[commit-bot: I haz the power, 2017-04-04 19:43:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dfdfa5a0d0415d80b0f284e14e90...

[Justin Novosad, 2017-04-05 18:14:39]

Description was changed from

==========
Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Original-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461803}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfdfa5a0d0415d80b0f284e14e90...
==========

to

==========
Convert colorSettings attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an
attribute. This CL fixes this by converting the colorSettings attribute in
ImageData interface to a getter method.

BUG=702578

Review-Url: https://codereview.chromium.org/2788373003
Cr-Original-Commit-Position: refs/heads/master@{#461567}
Committed:
https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5...
Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461803}
Committed:
https://chromium.googlesource.com/chromium/src/+/dfdfa5a0d0415d80b0f284e14e90...
==========