Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2794043002: [Extensions Bindings] Move safeCallbackApply to exception handler (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Move safeCallbackApply to exception handler Move the safeCallbackApply function to the uncaught exception handler module, rather than the sendRequest module. Two main reasons: - It makes more sense, since the purpose of the function is to run a supplied function and notify the exception handler on failure, - Moving to native bindings, we should be able to avoid using anything from the sendRequest module. BUG=653596 Review-Url: https://codereview.chromium.org/2794043002 Cr-Commit-Position: refs/heads/master@{#461538} Committed: https://chromium.googlesource.com/chromium/src/+/b026fbdecb915942a1dcff6fd664d664586dc56f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -44 lines) Patch
M chrome/renderer/resources/extensions/file_entry_binding_util.js View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 4 chunks +5 lines, -15 lines 0 comments Download
M extensions/renderer/resources/binding.js View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/resources/send_request.js View 3 chunks +2 lines, -10 lines 0 comments Download
M extensions/renderer/resources/uncaught_exception_handler.js View 2 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Devlin
Just movin' stuff around (I'm hoping to be able to blacklist send_request.js, event.js, binding.js, and ...
3 years, 8 months ago (2017-04-03 20:21:57 UTC) #6
lazyboy
lgtm
3 years, 8 months ago (2017-04-03 20:55:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794043002/1
3 years, 8 months ago (2017-04-03 20:56:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 21:09:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b026fbdecb915942a1dcff6fd664...

Powered by Google App Engine
This is Rietveld 408576698